Skip to content

[UR][L0] Fix the multi device event cache to allocate lists as pointers #12778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 22, 2024

Conversation

nrspruit
Copy link
Contributor

@nrspruit nrspruit force-pushed the fix_multidevice_event_cache branch from 50a5c25 to 391871e Compare February 21, 2024 03:36
@nrspruit nrspruit force-pushed the fix_multidevice_event_cache branch 2 times, most recently from 86926b7 to d026eb0 Compare February 21, 2024 03:57
@nrspruit nrspruit force-pushed the fix_multidevice_event_cache branch from d026eb0 to c90d9f6 Compare February 21, 2024 16:12
@nrspruit nrspruit force-pushed the fix_multidevice_event_cache branch from c90d9f6 to ddb3a7d Compare February 21, 2024 18:00
@nrspruit
Copy link
Contributor Author

nrspruit commented Feb 21, 2024

Failure seems unrelated:

# RUN: at line 35
env LD_PRELOAD=/__w/llvm/llvm/build-e2e/ESIMD/regression/Output/complex-lib-lin.cpp.tmp-lib-a.so env ONEAPI_DEVICE_SELECTOR=opencl:gpu  /__w/llvm/llvm/build-e2e/ESIMD/regression/Output/complex-lib-lin.cpp.tmp-a.run
# executed command: env LD_PRELOAD=/__w/llvm/llvm/build-e2e/ESIMD/regression/Output/complex-lib-lin.cpp.tmp-lib-a.so env ONEAPI_DEVICE_SELECTOR=opencl:gpu /__w/llvm/llvm/build-e2e/ESIMD/regression/Output/complex-lib-lin.cpp.tmp-a.run
# note: command had no output on stdout or stderr
# error: command failed with exit status: -11

The failure is with the opencl adapter....

- fix to address a multi device crash given many devices causing a stack overflow.
  Event Caches per device are now explicitly allocated.

- pre-commit PR for oneapi-src/unified-runtime#1366

Signed-off-by: Spruit, Neil R <neil.r.spruit@intel.com>
@kbenzie kbenzie marked this pull request as ready for review February 22, 2024 11:01
@kbenzie kbenzie requested a review from a team as a code owner February 22, 2024 11:01
@steffenlarsen
Copy link
Contributor

Windows Gen12:

Failed Tests (8):
  SYCL :: Assert/assert_in_kernels_win.cpp
  SYCL :: Assert/assert_in_multiple_tus_one_ndebug_win.cpp
  SYCL :: Assert/assert_in_multiple_tus_win.cpp
  SYCL :: Assert/assert_in_one_kernel_win.cpp
  SYCL :: Assert/assert_in_simultaneous_kernels_win.cpp
  SYCL :: Assert/assert_in_simultaneously_multiple_tus.cpp
  SYCL :: Assert/assert_in_simultaneously_multiple_tus_one_ndebug.cpp
  SYCL :: Plugin/sycl-ls-unified-runtime.cpp

Reported in #12797 and #12798

@steffenlarsen steffenlarsen merged commit 343d953 into intel:sycl Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants