This repository has been archived by the owner on Mar 28, 2023. It is now read-only.
[SYCL] Check that fp16 aspect is supported before using half #1487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v-klochkov
reviewed
Jan 4, 2023
| passed &= test<sycl::half>(); | ||
| passed &= test<float>(queue); | ||
| if (queue.get_device().has(sycl::aspect::fp16)) | ||
| passed &= test<sycl::half>(queue); |
There was a problem hiding this comment.
I believe the test compilation options need -fsycl-device-code-split=per_kernel to handle the aspects properly at runtime.
There was a problem hiding this comment.
per_kernel device code split is not actually needed anymore since intel/llvm#7302: the compiler is now able to automatically split kernels into separate modules if optional features are used
v-klochkov
approved these changes
Jan 4, 2023
npmiller
approved these changes
Jan 5, 2023
|
SYCL :: SubGroupMask/Basic.cpp is known and tracked. |
myler
pushed a commit
to myler/llvm-test-suite
that referenced
this pull request
Mar 22, 2023
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed to fix CI failure caused by new test, example: intel/llvm#7919