Skip to content

Check llvm::Expected before use #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

dvrogozh
Copy link
Contributor

Fixes: #77

That's effectively reuse of the same approach already used in IGC elsewhere:

if (llvm::Error EC = ModuleOrErr.takeError())

Fixes: intel#77

Signed-off-by: Dmitry Rogozhkin <dmitry.v.rogozhkin@intel.com>
@paigeale
Copy link
Contributor

paigeale commented Dec 6, 2019

Hello Dmitry,
Look like this pull request is already implemented with your change a0a1599.

Closing down

Thanks,
Alex Paige

@paigeale paigeale closed this Dec 6, 2019
@dvrogozh
Copy link
Contributor Author

Yes, it is addressed. Sorry for allowing dangling issue to hang.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

opencl-neo build fails on non-checked llvm::Expected on IGC side
2 participants