Fix queue casts which cause spirv to die with assert #143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 13, 2019
Closed
|
Build fails for clang <=5. @AlexeySotkin: do you have suggestions how to handle/fix that? |
Should be fixed by #142 |
dvrogozh
force-pushed
the
fix_spirv_assert
branch
from
54324f6 to
2a52858
Compare
|
@AlexeySotkin : thank you for #142. I rebased this one and CI passed. Folks, could you, please, review/feedback/merge? |
Fixes: intel/opencl-clang#46 This fixes ocloc build of scheduler.cl which dies with assert from spirv: SPIRV-LLVM-Translator/lib/SPIRV/SPIRVWriter.cpp:685 Signed-off-by: Dmitry Rogozhkin <dmitry.v.rogozhkin@intel.com>
|
Please update date in header. |
|
Code looks good. |
|
Please take a look at Section 3 covers commit message requirements. |
dvrogozh
force-pushed
the
fix_spirv_assert
branch
from
2a52858 to
b5e0091
Compare
dvrogozh
changed the title
VPG-SWE-Github
pushed a commit
that referenced
this pull request
Mar 18, 2019
Fixes: intel/opencl-clang#46 This fixes ocloc build of scheduler.cl which dies with assert from spirv: SPIRV-LLVM-Translator/lib/SPIRV/SPIRVWriter.cpp:685 Signed-off-by: Dmitry Rogozhkin <dmitry.v.rogozhkin@intel.com> #143 Change-Id: I5c9d4a75321008802b9d77ef4a6bad3812e1b8b4
|
Landed in master as 7a7bb50. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: intel/opencl-clang#46
That's RFC (request for comments) PR since I just followed suggestion from @AlexeySotkin here: intel/opencl-clang#46 (comment)
This fixes ocloc build of scheduler.cl which dies with assert from spirv:
SPIRV-LLVM-Translator/lib/SPIRV/SPIRVWriter.cpp:685
Thrown assert is:
SPIRV::SPIRVInstruction* SPIRV::LLVMToSPIRV::transUnaryInst(llvm::UnaryInstruction*, SPIRV::SPIRVBasicBlock*):
Assertion `Cast->getSrcTy()->getPointerAddressSpace() == SPIRAS_Generic' failed.
Mind that once I passed thru this failure, I see this issue in IGC: intel/intel-graphics-compiler#77. Fix is here: intel/intel-graphics-compiler#78