Skip to content

Fmt spdlog update #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 24, 2025
Merged

Fmt spdlog update #147

merged 2 commits into from
Jun 24, 2025

Conversation

dian-lun-lin
Copy link
Contributor

This PR addresses the clang compilation issue by updating fmt and spdlog to the latest version and implementing the necessary changes.

ethanglaser
ethanglaser approved these changes Jun 23, 2025
View reviewed changes
Copy link
Contributor

@ethanglaser ethanglaser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionally this is working as intended - though probably makes sense to either delete or revise the commented sections before merge

@dian-lun-lin
Copy link
Contributor Author

Functionally this is working as intended - though probably makes sense to either delete or revise the commented sections before merge

I commented it out as we should bring this test back when the fmt issue is solved in the future.

yuejiaointel
yuejiaointel approved these changes Jun 24, 2025
View reviewed changes
Copy link
Contributor

@yuejiaointel yuejiaointel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :D

@dian-lun-lin dian-lun-lin merged commit f4bc5f2 into intel:main Jun 24, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethanglaser ethanglaser ethanglaser approved these changes

@yuejiaointel yuejiaointel yuejiaointel approved these changes

@mihaic mihaic Awaiting requested review from mihaic mihaic is a code owner

@ibhati ibhati Awaiting requested review from ibhati ibhati is a code owner

@Alexsandruss Alexsandruss Awaiting requested review from Alexsandruss Alexsandruss is a code owner

@ahuber21 ahuber21 Awaiting requested review from ahuber21 ahuber21 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dian-lun-lin @ethanglaser @yuejiaointel