Fmt spdlog update (#147)

This PR addresses the clang compilation issue by updating `fmt` and
`spdlog` to the latest version and implementing the necessary changes.

Author: dian-lun-lin

cmake/fmt.cmake

@@ -17,7 +17,7 @@ set(FMT_INSTALL YES)
 FetchContent_Declare(
     fmt
     GIT_REPOSITORY https://github.com/fmtlib/fmt
-    GIT_TAG 10.1.1
+    GIT_TAG 11.2.0
 )
 FetchContent_MakeAvailable(fmt)
 target_link_libraries(${SVS_LIB} INTERFACE fmt::fmt)

cmake/spdlog.cmake

@@ -32,7 +32,7 @@ set(SPDLOG_FMT_EXTERNAL YES CACHE BOOL "" FORCE)
 FetchContent_Declare(
     spdlog
     GIT_REPOSITORY https://github.com/gabime/spdlog
-    GIT_TAG v1.13.0
+    GIT_TAG v1.15.3
 )
 FetchContent_MakeAvailable(spdlog)
 target_link_libraries(${SVS_LIB} INTERFACE spdlog::spdlog)

include/svs/lib/threads/types.h

@@ -430,12 +430,16 @@ DynamicPartition(const R&, size_t) -> DynamicPartition<typename R::const_iterato
 } // namespace threads
 } // namespace svs
 
-///// Formatting
-template <typename T>
-struct fmt::formatter<svs::threads::UnitRange<T>> : svs::format_empty {
-    auto format(const svs::threads::UnitRange<T>& x, auto& ctx) const {
-        return fmt::format_to(
-            ctx.out(), "UnitRange<{}>({}, {})", svs::datatype_v<T>, x.start(), x.stop()
-        );
-    }
-};
+// Clang-18+ fails to compile the following code.
+// The related fmt issue can be found here: https://github.com/gabime/spdlog/issues/3333
+// Comment out the code until the issue is resolved in an upcoming fmt update
+// Related test: tests/svs/lib/threads/types.cpp::printing
+// Formatting
+//template <typename T>
+//struct fmt::formatter<svs::threads::UnitRange<T>> : svs::format_empty {
+    //auto format(const svs::threads::UnitRange<T>& x, auto& ctx) const {
+        //return fmt::format_to(
+            //ctx.out(), "UnitRange<{}>({}, {})", svs::datatype_v<T>, x.start(), x.stop()
+        //);
+    //}
+//};

include/svs/third-party/fmt.h

@@ -20,6 +20,7 @@
 #include "fmt/core.h"
 #include "fmt/format.h"
 #include "fmt/std.h"
+#include "fmt/ranges.h"
 
 // stl
 #include <string_view>

tests/svs/lib/threads/types.cpp

@@ -200,11 +200,11 @@ CATCH_TEST_CASE("Thread Helper Types", "[core][threads]") {
             CATCH_REQUIRE(*(r.end() - 1) == 99);
         }
 
-        CATCH_SECTION("Printing") {
-            auto range = svs::threads::UnitRange<size_t>(100, 200);
-            auto repr = fmt::format("{}", range);
-            CATCH_REQUIRE(repr == "UnitRange<uint64>(100, 200)");
-        }
+        //CATCH_SECTION("Printing") {
+            //auto range = svs::threads::UnitRange<size_t>(100, 200);
+            //auto repr = fmt::format("{}", range);
+            //CATCH_REQUIRE(repr == "UnitRange<uint64>(100, 200)");
+        //}
 
         CATCH_SECTION("Indexing") {
             auto range = svs::threads::UnitRange(100, 200);