Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more prometheus metrics #1612

Merged
merged 28 commits into from
Oct 15, 2024
Merged

more prometheus metrics #1612

merged 28 commits into from
Oct 15, 2024

Conversation

brenzi
Copy link
Collaborator

@brenzi brenzi commented Oct 13, 2024

closes #1459 (or what's relevant)

enclave sourced metrics

  • rpc request + submitted TrustedCall metrics
  • STF execution duration histogram
  • STF execution numbers of success and failed calls histogram
  • fix top-pool-size which was brittle and drifted in the past
  • Runtime total issuance
  • parentchains last processed block taken from parentchain pallet
  • AURA execution stages remaining durations histograms per stage
  • state size as in-mem Bytes with shard identifier bs58 as label

service sourced metrics

  • enclave balance on all parentchains with parentchainId and account ss58 as labels
  • shard vault balance with shielding-target and account ss58 as labels
  • sidechain: number of connected peers
  • sidechain: last finalized block as reported by Integritee Network
  • MRENCLAVE bs58 of self as label
  • VERSION as label

test locally, add --enable-metrics:

./integritee-service -u ws://172.17.0.1 --ws-external --enable-metrics -c run --skip-ra --dev &> worker.log
# other terminal
curl localhost:8787/metrics

should roughly result in this: https://gist.github.com/brenzi/2e44db310fce7cde642a4a2e94604067

@brenzi brenzi marked this pull request as ready for review October 14, 2024 15:16
@brenzi brenzi added F8-enhancement New feature or request A0-core Affects a core part B1-releasenotes C1-low 📌 Does not elevate a release containing this beyond "low priority" E0-breaksnothing labels Oct 14, 2024
@brenzi brenzi requested a review from clangenb October 14, 2024 15:19
Copy link
Contributor

@clangenb clangenb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor things, but looks very good to me in general.

enclave-runtime/src/lib.rs Outdated Show resolved Hide resolved
core-primitives/enclave-metrics/src/lib.rs Outdated Show resolved Hide resolved
core-primitives/stf-executor/src/executor.rs Outdated Show resolved Hide resolved
core-primitives/stf-executor/src/executor.rs Show resolved Hide resolved
enclave-runtime/src/rpc/common_api.rs Show resolved Hide resolved
enclave-runtime/src/top_pool_execution.rs Show resolved Hide resolved
service/src/account_funding.rs Outdated Show resolved Hide resolved
service/src/main_impl.rs Show resolved Hide resolved
service/src/prometheus_metrics.rs Outdated Show resolved Hide resolved
core-primitives/top-pool-author/src/author.rs Show resolved Hide resolved
@brenzi brenzi requested a review from clangenb October 15, 2024 10:40
Copy link
Contributor

@clangenb clangenb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful, thanks for the fixes. Looks good to me.

@brenzi brenzi merged commit c4143d8 into master Oct 15, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A0-core Affects a core part B1-releasenotes C1-low 📌 Does not elevate a release containing this beyond "low priority" E0-breaksnothing F8-enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

expose additional prometheus metrics
2 participants