Skip to content

[BUG] Type mismatch in team_id of emu_group_mapping #3163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nickfloyd merged 2 commits into from
Feb 9, 2026
Merged

[BUG] Type mismatch in team_id of emu_group_mapping #3163

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2b7820a
Fix `team_id` type to be `TypeInt` instead of `TypeString`
deiga Feb 7, 2026
5d5d354
Ensure migration also uses correct type
deiga Feb 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions github/resource_github_emu_group_mapping.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ func resourceGithubEMUGroupMapping() *schema.Resource {
Description: "Manages the mapping of an external group to a GitHub team.",
Schema: map[string]*schema.Schema{
"team_id": {
Type: schema.TypeString,
Type: schema.TypeInt,
Computed: true,
Description: "ID of the GitHub team.",
},
Expand Down Expand Up @@ -99,7 +99,7 @@ func resourceGithubEMUGroupMappingCreate(ctx context.Context, d *schema.Resource
return diag.FromErr(err)
}

if err := d.Set("team_id", teamID); err != nil {
if err := d.Set("team_id", int(teamID)); err != nil {
return diag.FromErr(err)
}

Expand Down Expand Up @@ -334,7 +334,7 @@ func resourceGithubEMUGroupMappingImport(ctx context.Context, d *schema.Resource
return nil, err
}

if err := d.Set("team_id", teamID); err != nil {
if err := d.Set("team_id", int(teamID)); err != nil {
return nil, err
}

Expand Down
2 changes: 1 addition & 1 deletion github/resource_github_emu_group_mapping_migration.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ func resourceGithubEMUGroupMappingStateUpgradeV0(ctx context.Context, rawState m
if err != nil {
return nil, err
}
rawState["team_id"] = teamID
rawState["team_id"] = int(teamID)
resourceID, err := buildID(strconv.FormatInt(teamID, 10), teamSlug, strconv.FormatInt(group.GetGroupID(), 10))
if err != nil {
return nil, err
Expand Down
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ go 1.24.4

require (
github.com/go-jose/go-jose/v3 v3.0.4
github.com/google/go-cmp v0.7.0
github.com/google/go-github/v82 v82.0.0
github.com/google/uuid v1.6.0
github.com/hashicorp/go-cty v1.5.0
Expand All @@ -22,6 +21,7 @@ require (
github.com/cloudflare/circl v1.6.1 // indirect
github.com/fatih/color v1.18.0 // indirect
github.com/golang/protobuf v1.5.4 // indirect
github.com/google/go-cmp v0.7.0 // indirect
github.com/google/go-querystring v1.2.0 // indirect
github.com/hashicorp/errwrap v1.0.0 // indirect
github.com/hashicorp/go-checkpoint v0.5.0 // indirect
Expand Down