[BUG] Type mismatch in team_id of emu_group_mapping

[deiga]

Resolves #3160

---

Before the change?

• Creating new github_emu_group_mapping resources fails as team_id is being populated with the wrong type

After the change?

• Creating new github_emu_group_mapping resources works as team_id is being populated with the correct type

Pull request checklist

• Schema migrations have been created if needed (example)
• Tests for the changes have been added (for bug fixes / features)
• Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

• Yes
• No

---

[github-actions]

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

[stevehipwell]

LGTM

[tobias-schuemann]

@nickfloyd thanks for the fix. Do you have a release date for the patch?

[deiga]

@tobias-schuemann We're aiming for within the next 24h, barring obstacles

[stevehipwell]

@deiga I've only just spotted this, but why hasn't the ID be corrected to match the input ID? The resource is scoped to the EMU group, so I'd expect the ID to be <group-id>:<team-id> as it is in the import? Also why is the ID using 3 parts instead of the 2 parts used for this pattern elsewhere in the re-written provider code?

[deiga]

@stevehipwell That's an excellent question. I guess it fell through the cracks.

I agree that using the 2 part ID sounds more reasonable

[stevehipwell]

@deiga is this something you could put a PR in for (with migration)?