APPDUX-228: Fixes to incorporate latest PF4 breaking change release#596
APPDUX-228: Fixes to incorporate latest PF4 breaking change release#596mfrances17 merged 3 commits intointegr8ly:masterfrom
Conversation
mfrances17
requested review from
christiemolloy,
dlabaj,
jenny-s51,
pb82 and
tiffanynolan
jenny-s51
left a comment
jenny-s51
left a comment
There was a problem hiding this comment.
Looking good @mfrances17 ! There's a slight spacing issue with the breadcrumb:
which Zack fixed here patternfly/patternfly-react#4368 and released in "@patternfly/react-core": "4.18.13", ... Can we bump react-core to 4.18.13? I tested locally and didn't run into any problems.
package.json
Outdated
| "@patternfly/react-core": "3.124.1", | ||
| "@patternfly/react-icons": "^3.14.23", | ||
| "@patternfly/patternfly": "4.10.29", | ||
| "@patternfly/react-core": "4.18.1", |
There was a problem hiding this comment.
can we bump to 4.18.13?
There was a problem hiding this comment.
I've updated to the latest PF:
patternfly: 4.16.7
react-core: 4.23.1
|
Lgtm |
|
@jenny-s51 @dlabaj @christiemolloy @pb82 @tiffanynolan Updated with the latest Patternfly 4 release... can be tested locally or on my server: |
|
Looking great! I noticed that the right side padding/gutter is missing from the data list. Can you add that back in? |
|
Also, there is some extra padding between the tab bar and the data list. Can this be removed? |
|
Fixed the issues @tiffanynolan found, put an image of the latest on my server. Please have a look at your earliest convenience: Screen caps as well, for your convenience:
|
tiffanynolan
left a comment
tiffanynolan
left a comment
There was a problem hiding this comment.
Thanks for the changes. lgtm!
4 participants
Motivation
https://issues.redhat.com/browse/APPDUX-228
What
Update to the latest Patternfly 4 build and make fixes so the UI behavior and look and feel work as expected.
Why
To incorporate the latest PF4 components going forward.
Verification Steps
Open Solution Explorer and traverse the entire UI to verify that no new issues were introduced.
Checklist:
Progress
Additional Notes
You can test effectively by pulling down this branch and running locally, but if you want to test on a server, you can use this docker image of the solution explorer:
docker.io/mfrances17/dev-tutorial-web-app:pf4-latest
Various screen caps:
