Skip to content

fix(breadcrumb): temp fix for spacing#4368

Merged
redallen merged 2 commits intopatternfly:masterfrom
redallen:fix/breadcrumb-spacing
Jun 11, 2020
Merged

fix(breadcrumb): temp fix for spacing#4368
redallen merged 2 commits intopatternfly:masterfrom
redallen:fix/breadcrumb-spacing

Conversation

@redallen
Copy link
Contributor

@redallen redallen commented Jun 10, 2020

What: Closes #4367

Additional issues: With this approach we should deprecate isActive and set the prop on the last element of <Breadcrumb>.

@patternfly-build
Copy link
Collaborator

patternfly-build commented Jun 10, 2020

Copy link
Contributor

@jenny-s51 jenny-s51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@tlabaj tlabaj requested a review from mcoker June 11, 2020 20:16
Copy link
Contributor

@mcoker mcoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spectacular 👍

@redallen redallen merged commit 7010497 into patternfly:master Jun 11, 2020
@patternfly-build
Copy link
Collaborator

Your changes have been released in:

  • @patternfly/react-catalog-view-extension@4.3.20
  • @patternfly/react-core@4.18.13
  • @patternfly/react-docs@5.3.34
  • @patternfly/react-inline-edit-extension@4.4.22
  • demo-app-ts@4.13.14
  • @patternfly/react-table@4.5.15
  • @patternfly/react-topology@4.3.22
  • @patternfly/react-virtualized-extension@4.3.22

Thanks for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix breadcrumb spacing

5 participants