Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to CONTRIBUTOR_ROLES based on recent nominations #297

Merged
merged 1 commit into from
May 30, 2024

Conversation

nathan-weinberg
Copy link
Member

@nathan-weinberg nathan-weinberg commented May 29, 2024

Summary of Changes:

  • Oversight Committee now exists, so updated the doc to reflect as such
  • Noted this doc serves as the contributor roles for all repos if no repo-specifc doc exists
  • Removed options for Maintainer Nominees to sponser themselves (a sponsee should open the issue instead)
  • Removed email requirement in favor of new nomination GitHub Issue template
  • Change private voting to public

@russellb
Copy link
Member

As discussed on Upstream Slack here

Can you replace this with an overview of the changes here? That link will be dead in a month.

@nathan-weinberg
Copy link
Member Author

As discussed on Upstream Slack here

Can you replace this with an overview of the changes here? That link will be dead in a month.

Yes can do 👍

@russellb
Copy link
Member

As discussed on Upstream Slack here

Can you replace this with an overview of the changes here? That link will be dead in a month.

Yes can do 👍

Thanks -- ideally all of the same detail goes into the commit message, as well. not a huge deal ... more of just a "best practices" thing to keep in mind

Copy link
Member

@russellb russellb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

some minor suggested edits

CONTRIBUTOR_ROLES.md Outdated Show resolved Hide resolved
CONTRIBUTOR_ROLES.md Outdated Show resolved Hide resolved
CONTRIBUTOR_ROLES.md Outdated Show resolved Hide resolved
CONTRIBUTOR_ROLES.md Outdated Show resolved Hide resolved
CONTRIBUTOR_ROLES.md Outdated Show resolved Hide resolved
The Oversight Committee now exists, so updated the doc to reflect as such
Noted this doc serves as the contributor roles for all repos if no repo-specifc doc exists
Removed options for Maintainer Nominees to sponsor themselves
Removed email requirement in favor of new nomination GitHub Issue template
Change private Maintainer voting to public

Co-authored-by: Russell Bryant <rbryant@redhat.com>
Signed-off-by: Nathan Weinberg <nweinber@redhat.com>
@russellb russellb merged commit 17d317e into instructlab:main May 30, 2024
4 checks passed
@nathan-weinberg nathan-weinberg deleted the workin branch November 4, 2024 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants