Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CONTRIBUTOR_ROLES: More 'Reviewer' pruning #298

Merged
merged 2 commits into from
May 29, 2024

Conversation

wking
Copy link
Contributor

@wking wking commented May 29, 2024

Cleaning up some references that slipped through 85e1588 (#188).

Also dropping the note about frequent-contributors being expected to work towards becoming Reviewers. We could probably have used Triager there, but contributions are hard, and being a triager is hard, and we want to encourage folks who have the time to do either, without pressuring folks into filling both roles. Maintainers are certainly welcome to reach out to frequent contributors to invite them to become Triagers, and I've added text around that, but that's not something that needs text in the Member section.

Cleaning up some references that slipped through 85e1588
(CONTRIBUTOR_ROLES: Remove reviewer role, 2024-04-17, instructlab#188).

Also dropping the note about frequent-contributors being expected to
work towards becoming Reviewers.  We could probably have used Triager
there, but contributions are hard, and being a triager is hard, and we
want to encourage folks who have the time to do either, without
pressuring folks into filling both roles.  Maintainers are certainly
welcome to reach out to frequent contributors to invite them to become
Triagers, and I've added text around that, but that's not something
that needs text in the Member section.

Signed-off-by: W. Trevor King <wking@tremily.us>
@wking wking requested a review from a team as a code owner May 29, 2024 22:23
Copy link
Member

@russellb russellb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @wking ! I noticed one other thing in a line you changed.

CONTRIBUTOR_ROLES.md Outdated Show resolved Hide resolved
Fix an old reference to the oversight committee from before it was created.

Signed-off-by: Russell Bryant <rbryant@redhat.com>
Copy link
Member

@russellb russellb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I applied my suggested edit.

@russellb russellb merged commit 8114704 into instructlab:main May 29, 2024
4 checks passed
@wking wking deleted the Reviewers-to-Triagers branch May 30, 2024 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants