Skip to content

Cassandra refactor #486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 27, 2023
Merged

Cassandra refactor #486

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
361a0db
refactor(cassandra_inst): Reduce cyclomatic complexity with early return
Ferenc- Dec 22, 2023
a2e657d
refactor(cassandra_inst): Use start_active_span as scope manager
Ferenc- Dec 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 16 additions & 18 deletions instana/instrumentation/cassandra_inst.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,24 +54,22 @@ def cb_request_error(results, span, fn):
def request_init_with_instana(fn):
active_tracer = get_active_tracer()

if active_tracer is not None:
parent_span = active_tracer.active_span
ctags = dict()
if isinstance(fn.query, cassandra.query.SimpleStatement):
ctags["cassandra.query"] = fn.query.query_string
elif isinstance(fn.query, cassandra.query.BoundStatement):
ctags["cassandra.query"] = fn.query.prepared_statement.query_string

ctags["cassandra.keyspace"] = fn.session.keyspace
ctags["cassandra.cluster"] = fn.session.cluster.metadata.cluster_name

span = active_tracer.start_span(
operation_name="cassandra",
child_of=parent_span,
tags=ctags)

fn.add_callback(cb_request_finish, span, fn)
fn.add_errback(cb_request_error, span, fn)
if active_tracer is None:
return

ctags = {}
if isinstance(fn.query, cassandra.query.SimpleStatement):
ctags["cassandra.query"] = fn.query.query_string
elif isinstance(fn.query, cassandra.query.BoundStatement):
ctags["cassandra.query"] = fn.query.prepared_statement.query_string

ctags["cassandra.keyspace"] = fn.session.keyspace
ctags["cassandra.cluster"] = fn.session.cluster.metadata.cluster_name

with active_tracer.start_active_span("cassandra", child_of=active_tracer.active_span,
tags=ctags, finish_on_close=False) as scope:
fn.add_callback(cb_request_finish, scope.span, fn)
fn.add_errback(cb_request_error, scope.span, fn)


@wrapt.patch_function_wrapper('cassandra.cluster', 'Session.__init__')
Expand Down