Skip to content

Cassandra refactor #486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 27, 2023
Merged

Cassandra refactor #486

merged 2 commits into from
Dec 27, 2023

Conversation

@Ferenc-
Copy link
Member

@Ferenc- Ferenc- commented Dec 22, 2023

No description provided.

@Ferenc- Ferenc- requested review from GSVarsha and pvital December 22, 2023 11:58
@Ferenc-
refactor(cassandra_inst): Reduce cyclomatic complexity with early return
361a0db 
Signed-off-by: Ferenc Géczi <ferenc.geczi@ibm.com>
@Ferenc-
refactor(cassandra_inst): Use start_active_span as scope manager
a2e657d 
Signed-off-by: Ferenc Géczi <ferenc.geczi@ibm.com>
GSVarsha
GSVarsha approved these changes Dec 27, 2023
View reviewed changes
Copy link
Contributor

@GSVarsha GSVarsha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@Ferenc- Ferenc- merged commit 6293143 into master Dec 27, 2023
@Ferenc- Ferenc- deleted the cassandra-refactor branch December 27, 2023 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GSVarsha GSVarsha GSVarsha approved these changes

@pvital pvital Awaiting requested review from pvital

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Ferenc- @GSVarsha