Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQL labels, MM updates #254

Merged
merged 10 commits into from
Apr 28, 2020
Merged

SQL labels, MM updates #254

merged 10 commits into from
Apr 28, 2020

Conversation

slevenick
Copy link
Collaborator

Description

Update MM

Issues Resolved

#253

modular-magician and others added 8 commits April 16, 2020 13:15
* Add encryption, retention policy to buckets

* snake case

* Typo

* Typo

* Add test, fix docs on sa key

* Remove test

Signed-off-by: Modular Magician <magic-modules@google.com>
Signed-off-by: Modular Magician <magic-modules@google.com>
* SD for Cloud DNS

* use getRelativePath

Signed-off-by: Modular Magician <magic-modules@google.com>
* more product renames

* fix empty display names

* more moves

Signed-off-by: Modular Magician <magic-modules@google.com>
* adds scaling properties to appengine standard version

* use optional scaling properties

as it defaults to automaticScaling

* cover all automatic_scaling properties during test

* update test for standard appengine version

Signed-off-by: Modular Magician <magic-modules@google.com>
* Add enum values generation to documentation, remove previous handwritten lists unless they add value

* Add possible enum values to inspec doc generation

* Add default, possible values to the schema description

* Format fixes

* Try spacing to see how md looks

* PR feedback

* Order of operations

* Bigger spacefor markdown

Signed-off-by: Modular Magician <magic-modules@google.com>
Signed-off-by: Modular Magician <magic-modules@google.com>
@slevenick slevenick requested a review from a team as a code owner April 24, 2020 23:15
modular-magician and others added 2 commits April 24, 2020 19:16
* Add user labels kv map to sql instance

* Add userLabels to sql instance

Signed-off-by: Modular Magician <magic-modules@google.com>
Signed-off-by: Sam Levenick <slevenick@google.com>
Copy link

@skpaterson skpaterson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, thanks @slevenick !

@skpaterson skpaterson added the Version: Bump Minor Used by github.minor_bump_labels to bump the Minor version number. label Apr 28, 2020
@skpaterson skpaterson merged commit b156926 into inspec:master Apr 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Version: Bump Minor Used by github.minor_bump_labels to bump the Minor version number.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants