This repository has been archived by the owner on Nov 14, 2024. It is now read-only.
adds scaling properties to appengine standard version #386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* adds scaling properties to appengine standard version * use optional scaling properties as it defaults to automaticScaling * cover all automatic_scaling properties during test * update test for standard appengine version Signed-off-by: Modular Magician <magic-modules@google.com>
slevenick
pushed a commit
that referenced
this pull request
May 5, 2020
* adds scaling properties to appengine standard version * use optional scaling properties as it defaults to automaticScaling * cover all automatic_scaling properties during test * update test for standard appengine version Signed-off-by: Modular Magician <magic-modules@google.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Note Template for Downstream PRs (will be copied)
This adds
automaticScaling,basicScaling, andmanualScalingproperties to AppEngine Standard. These are similar to the scaling properties that already existed on AppEngine Flexible, but there are some notable differences. Based on the Google API documentation and trying all properties, I've removed all the properties that are not allowed for AppEngine Standard as we have different resources for AppEngine Standard and AppEngine Flex.I have also marked
deploymentas required for AppEngine Standard. I couldn't find a reason in the commit history why this was marked as not required, and testing has shown that omitting thedeploymentthrows a 400.Derived from GoogleCloudPlatform/magic-modules#3373