Skip to content

Switch to bslib #259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 23, 2025
Merged

Switch to bslib #259

merged 3 commits into from
May 23, 2025

Conversation

vedhav
Copy link
Contributor

@vedhav vedhav commented May 7, 2025

Closes #250

@vedhav vedhav added the core label May 7, 2025
Copy link
Contributor

github-actions bot commented May 7, 2025

✅ All contributors have signed the CLA
Posted by the CLA Assistant Lite bot.

@vedhav
Copy link
Contributor Author

vedhav commented May 7, 2025

I have read the CLA Document and I hereby sign the CLA

@averissimo
Copy link
Contributor

@vedha do you think we should change the CSS color to a bslib variable (#e3e3e3 -> var(--bs-gray-200))

@llrs-roche
Copy link
Contributor

@vedhav FYI: if the remaining changes are like this I don't see a conflict with the extraction feature:
image

@vedhav vedhav marked this pull request as ready for review May 22, 2025 06:50
Copy link
Contributor

github-actions bot commented May 22, 2025

badge

Code Coverage Summary

Filename                          Stmts    Miss  Cover    Missing
------------------------------  -------  ------  -------  ------------------------------------------------------------------------------
R/call_utils.R                      156     124  20.51%   19-28, 65, 67, 69, 102-345
R/check_selector.R                   33       0  100.00%
R/choices_labeled.R                 157      27  82.80%   68, 74, 79, 86, 102, 220-224, 228-233, 357-358, 360, 366, 393-400
R/choices_selected.R                 81      11  86.42%   214-242, 279
R/column_functions.R                  3       3  0.00%    15-18
R/data_extract_datanames.R           30       8  73.33%   16-20, 83-85
R/data_extract_filter_module.R      105      47  55.24%   95-108, 111-112, 114-131, 147-166
R/data_extract_module.R             305      67  78.03%   140, 145, 162, 165-170, 172, 191-194, 224-270, 509, 514, 691, 702-703, 781-786
R/data_extract_read_module.R        137       7  94.89%   34, 39-41, 43, 138, 155
R/data_extract_select_module.R       32      18  43.75%   29-46
R/data_extract_single_module.R       60       2  96.67%   30, 43
R/data_extract_spec.R                32       0  100.00%
R/delayed_choices.R                  34       6  82.35%   87, 96-100
R/filter_spec.R                     186       1  99.46%   280
R/format_data_extract.R              16       1  93.75%   48
R/get_dplyr_call.R                  297       0  100.00%
R/get_merge_call.R                  278      29  89.57%   32-38, 49, 215-224, 391, 407-419
R/input_checks.R                     11       2  81.82%   17-18
R/merge_data_utils.R                  2       0  100.00%
R/merge_datasets.R                  134       6  95.52%   123, 249-253
R/merge_expression_module.R          60      11  81.67%   161-166, 184, 362-367
R/Queue.R                            23       0  100.00%
R/resolve_delayed.R                  16       4  75.00%   78-81
R/resolve.R                         115      45  60.87%   48, 182-288
R/select_spec.R                      64       8  87.50%   99, 179-186
R/utils.R                            37      24  35.14%   33-46, 174-187
R/zzz.R                               3       3  0.00%    2-4
TOTAL                              2407     454  81.14%

Diff against main

Filename                   Stmts    Miss  Cover
-----------------------  -------  ------  -------
R/data_extract_module.R       +7       0  +0.52%
TOTAL                         +7       0  +0.02%

Results for commit: fcc428a

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

github-actions bot commented May 22, 2025

Unit Tests Summary

  1 files   24 suites   7s ⏱️
194 tests 194 ✅ 0 💤 0 ❌
697 runs  697 ✅ 0 💤 0 ❌

Results for commit fcc428a.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@averissimo averissimo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall 💯, but there's a warning in CI

@averissimo averissimo self-assigned this May 22, 2025
@vedhav vedhav enabled auto-merge (squash) May 23, 2025 02:56
Copy link
Contributor

@averissimo averissimo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@vedhav vedhav merged commit 2ebbcb0 into main May 23, 2025
29 checks passed
@vedhav vedhav deleted the 250-switch-to-bslib@main branch May 23, 2025 14:14
@github-actions github-actions bot locked and limited conversation to collaborators May 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch to bslib
3 participants