[Docs] Update module arg docs to only accept choices_selected
#1078
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Unit Tests Summary 1 files 33 suites 3s ⏱️ Results for commit 36fd86a. ♻️ This comment has been updated with latest results. |
shajoezhu
requested changes
Feb 22, 2024
Contributor
shajoezhu
left a comment
shajoezhu
left a comment
There was a problem hiding this comment.
Thank you so much @vedhav ! Agreed! this should be changed, I am waiting for tmc cran feedback, hopefully hearing back soon today. if more changes needed, we will include this PR in as well. Thanks!
in the meantime, could you update the news.md as well. Thanks
shajoezhu
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1076
Changes
choices_selectedand notdata_extract_specAfter this change, all the example apps were run successfully. Here is a sheet that was used to track the changes.
P.S I am unsure where I should target this change, and I can change the target branch if needed.