Cran release 0.9.0 [skip vbump]

[shajoezhu]

close #920

[shajoezhu]

Dear package maintainer,

this notification has been generated automatically.
Your package teal.modules.clinical_0.9.0.tar.gz has been built (if working) and checked for Windows.
Please check the log files and (if working) the binary package at:
https://win-builder.r-project.org/CO4dsMs6xlWw
The files will be removed after roughly 72 hours.
Installation time in seconds: 38
Check time in seconds: 329
Status: 1 NOTE
R version 4.3.2 (2023-10-31 ucrt)

[github-actions]

Unit Tests Summary

  1 files   33 suites   2s ⏱️
150 tests 150 ✅   0 💤 0 ❌
282 runs  170 ✅ 112 💤 0 ❌

Results for commit 2087c0b.

♻️ This comment has been updated with latest results.

[shajoezhu]

package submitted, waiting for feedback

[m7pr]

I think in this line of DESCRIPTION the teal could be written with ' such quotes

clinical trial reports. By leveraging the `teal` framework, this

[m7pr]

This line

teal.modules.clinical/DESCRIPTION

Line 28 in b0bead8

License: Apache License 2.0 | file LICENSE

could also be improved to License: Apache License 2.0 so there is no file mentioned. Our LICENSE files is a duplication and states Apache License 2.0. So no need to state our LICENSE is Apachce License 2.0 and something mentioned in a LICENSE file.

Also LICENSE file is listed in .Rbuildignore so would not land with a package submitted to CRAN as it's not gonna be included in .tar.gz file that you upload to CRAN.

[m7pr]

Added a PR that I think should be merged before the CRAN submission #1072

[shajoezhu]

cran feedback

Thanks,

If there are references describing the methods in your package, please
add these in the description field of your DESCRIPTION file in the form
authors (year) <doi:...>
authors (year) <arXiv:...>
authors (year, ISBN:...)
or if those are not available: <https:...>
with no space after 'doi:', 'arXiv:', 'https:' and angle brackets for
auto-linking. (If you want to add a title as well please put it in
quotes: "Title")

Please use only undirected quotation marks in the description text.
e.g. `teal` --> 'teal'

Please always write package names, software names and API (application
programming interface) names in single quotes in title and description.
e.g: --> 'teal'
Please note that package names are case sensitive.

Please add \value to .Rd files regarding exported methods and explain
the functions results in the documentation. Please write about the
structure of the output (class) and also what the output means. (If a
function does not return a value, please document that too, e.g.
\value{No return value, called for side effects} or similar)

-> Missing Rd-tags:
       bracket_expr.Rd: \value
       call_concatenate.Rd: \value
       clean_description.Rd: \value
       color_lab_values.Rd: \value
       extract_input.Rd: \value
       pipe_expr.Rd: \value
       prepare_arm_levels.Rd: \value
       prepare_arm.Rd: \value
       split_choices.Rd: \value
       split_col_expr.Rd: \value
       split_interactions.Rd: \value

Additionally, we see:
The LICENSE file is only needed if you have additional restrictions to
the license which you have not? In that case omit the file and its
reference in the DESCRIPTION file.

in summary todos

• update descirption, see 1071 prerelease cleanup@main #1072
• remove license, see in 1071 prerelease cleanup@main #1072
• add \value to rd files, see Please add \value to .Rd files regarding exported methods and explain the functions results in the documentation.  #1074

[shajoezhu]

resubmitted

[m7pr]

fingers crossed!

[shajoezhu]

we still see one 'teal'-instance not in single quotes.
Please always write package names, software names and API (application
programming interface) names in single quotes in title and description.
e.g: --> 'teal' in "...this package provides teal modules to easily
create..."

Please fix and resubmit.

[shajoezhu]

will merge #1078 in before resubmit