Moved relevant decoration expansion into formatters for rlistings fix #813
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Unit Tests Summary 1 files 24 suites 1m 37s ⏱️ For more details on these errors, see this check. Results for commit 94fc60a. ♻️ This comment has been updated with latest results. |
Contributor
Unit Test Performance Difference
Results for commit 5f1809b ♻️ This comment has been updated with latest results. |
5 tasks
Melkiades
deleted the
243_fix_nl_expansion@remove_decoration_nl_matrix_form@main
branch
Melkiades
added a commit
to insightsengineering/formatters
that referenced
this pull request
Jan 19, 2024
…246) Fixes the following issues - [x] #243 - [x] #232 - [x] insightsengineering/rlistings#183 - [x] True fix for insightsengineering/rlistings#155 - [x] insightsengineering/scda.test#99 To merge with insightsengineering/rlistings#192 (tests and misc) and insightsengineering/rtables#813 (tests and removed titles/footers newline handling) --------- Signed-off-by: Davide Garolini <dgarolini@gmail.com> Co-authored-by: 27856297+dependabot-preview[bot]@users.noreply.github.com <27856297+dependabot-preview[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant changes for insightsengineering/formatters#243. To merge after insightsengineering/formatters#246