Skip to content

Test: execute full workspace tests on macOS/Windows excluding unsupported packages #2485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 16, 2025
Merged

Test: execute full workspace tests on macOS/Windows excluding unsupported packages #2485

merged 1 commit into from
May 16, 2025
+23 −3

Conversation

dlachaume
Copy link
Collaborator

@dlachaume dlachaume commented May 15, 2025 •
edited
Loading

Content

This PR includes updates to the test job in the CI. It now runs tests across the full workspace on macOS and Windows, skipping unsupported packages.

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • CHANGELOG file is updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • All check jobs of the CI have succeeded
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update README file (if relevant)
    • Update documentation website (if relevant)
    • Add dev blog post (if relevant)
    • Add ADR blog post or Dev ADR entry (if relevant)
    • No new TODOs introduced

Issue(s)

Closes #2486

@dlachaume dlachaume self-assigned this May 15, 2025
@dlachaume dlachaume changed the title Test: execute full workspace tests excluding unsupported packages on macOS/Windows Test: execute full workspace tests on macOS/Windows excluding unsupported packages May 15, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented May 15, 2025 •
edited
Loading

Test Results

    3 files  ±  0     77 suites  +20   14m 43s ⏱️ + 3m 23s
1 913 tests ±  0  1 913 ✅ ±  0  0 💤 ±0  0 ❌ ±0 
3 225 runs  +832  3 225 ✅ +832  0 💤 ±0  0 ❌ ±0 

Results for commit 7e6279c. ± Comparison against base commit 5512099.

♻️ This comment has been updated with latest results.

@dlachaume dlachaume force-pushed the dlachaume/run-internal-crates-test-on-macos-windows-in-ci branch from 081c30a to 3152d3f Compare May 16, 2025 07:37
@dlachaume dlachaume marked this pull request as ready for review May 16, 2025 07:42
@dlachaume dlachaume force-pushed the dlachaume/run-internal-crates-test-on-macos-windows-in-ci branch 2 times, most recently from 02d9256 to 7254e54 Compare May 16, 2025 08:19
@dlachaume dlachaume marked this pull request as draft May 16, 2025 08:19
@dlachaume dlachaume force-pushed the dlachaume/run-internal-crates-test-on-macos-windows-in-ci branch 4 times, most recently from 6e8b744 to bdc9289 Compare May 16, 2025 09:32
@dlachaume dlachaume temporarily deployed to testing-preview May 16, 2025 09:45 — with GitHub Actions Inactive
@dlachaume dlachaume marked this pull request as ready for review May 16, 2025 09:45
jpraynaud
jpraynaud reviewed May 16, 2025
View reviewed changes
@dlachaume dlachaume force-pushed the dlachaume/run-internal-crates-test-on-macos-windows-in-ci branch 3 times, most recently from 7a62b17 to c9dad5e Compare May 16, 2025 10:48
@dlachaume dlachaume temporarily deployed to testing-preview May 16, 2025 10:59 — with GitHub Actions Inactive
jpraynaud
jpraynaud approved these changes May 16, 2025
View reviewed changes
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dlachaume dlachaume force-pushed the dlachaume/run-internal-crates-test-on-macos-windows-in-ci branch from c9dad5e to 98a1e19 Compare May 16, 2025 13:20
Alenar
Alenar approved these changes May 16, 2025
View reviewed changes
@dlachaume dlachaume force-pushed the dlachaume/run-internal-crates-test-on-macos-windows-in-ci branch from 98a1e19 to 40c1ec1 Compare May 16, 2025 13:31
@dlachaume dlachaume force-pushed the dlachaume/run-internal-crates-test-on-macos-windows-in-ci branch from 40c1ec1 to 7e6279c Compare May 16, 2025 13:35
@dlachaume dlachaume temporarily deployed to testing-preview May 16, 2025 13:44 — with GitHub Actions Inactive
@dlachaume dlachaume merged commit 895149d into main May 16, 2025
38 checks passed
@dlachaume dlachaume deleted the dlachaume/run-internal-crates-test-on-macos-windows-in-ci branch May 16, 2025 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alenar Alenar Alenar approved these changes

@jpraynaud jpraynaud jpraynaud approved these changes

@turmelclem turmelclem Awaiting requested review from turmelclem

Assignees

@dlachaume dlachaume

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Run internal crates tests on MacOS/Windows in the CI
3 participants
@dlachaume @Alenar @jpraynaud