Skip to content

Fix: URL for snapshot location is wrong #224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 1, 2022
Merged

Fix: URL for snapshot location is wrong #224

merged 1 commit into from
Jun 1, 2022

Conversation

jpraynaud
Copy link
Member

Fix missing config environment vars which caused the loading of development configuration in production

Closes #223

@jpraynaud jpraynaud requested review from a user, Alenar and ghubertpalo May 31, 2022 07:57
ghost
ghost reviewed May 31, 2022
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had something different in mind, so that we would still get a URL pointing at the aggregator but resolvable. This makes the client independent from google storage, which makes it possible to re-privatise the google bucket. WDYT?

@jpraynaud
Copy link
Member Author

We will address the resolvable urls in issue #232 and use this PR only for fixing the current misconfiguration

@jpraynaud jpraynaud merged commit a270709 into main Jun 1, 2022
@jpraynaud jpraynaud deleted the jpraynaud/223-add-env-vars-docker-compose branch June 1, 2022 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghubertpalo ghubertpalo ghubertpalo approved these changes

@Alenar Alenar Awaiting requested review from Alenar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

URL for snapshot location is wrong
2 participants
@jpraynaud @ghubertpalo