feat(cardano-chain-follower): Implementation #43
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FelipeRosa
force-pushed
the
cardano-chain-follower-impl
branch
from
d860deb to
bf65a32
Compare
FelipeRosa
changed the title
FelipeRosa
force-pushed
the
cardano-chain-follower-api-design
branch
2 times, most recently
from
ce58da3 to
db18905
Compare
FelipeRosa
force-pushed
the
cardano-chain-follower-impl
branch
from
bf65a32 to
9a78d02
Compare
FelipeRosa
force-pushed
the
cardano-chain-follower-api-design
branch
from
db18905 to
1f5233a
Compare
FelipeRosa
force-pushed
the
cardano-chain-follower-impl
branch
from
9a78d02 to
b4d42c8
Compare
FelipeRosa
requested review from
Mr-Leshiy,
cong-or,
minikin,
saibatizoku and
stevenj
as code owners
minikin
previously requested changes
Dec 25, 2023
hermes/crates/cardano-chain-follower/examples/read_block_range.rs
Outdated
Show resolved
Hide resolved
added 14 commits
January 3, 2024 10:14
FelipeRosa
force-pushed
the
cardano-chain-follower-api-design
branch
from
29ccdb9 to
f85cb88
Compare
FelipeRosa
force-pushed
the
cardano-chain-follower-impl
branch
from
9ac0d60 to
6a1a451
Compare
stevenj
previously approved these changes
Jan 4, 2024
Collaborator
stevenj
left a comment
stevenj
left a comment
There was a problem hiding this comment.
LGTM but need to correct conflicts now that earlier PR has merged.
stevenj
reviewed
Jan 9, 2024
Collaborator
stevenj
left a comment
stevenj
left a comment
There was a problem hiding this comment.
Should remove the Cargo.lock
This is also waiting on integration with the Mithril snapshot data, correct?
* feat(cardano-chain-follower): Split reader and follower and reader now supports reading single block and block ranges from Mithril snapshots * feat(cardano-chain-follower): Follower now uses request-response to communicate with its background task * feat(cardano-chain-follower): Follower reads blocks from Mithril snapshot (if configured) * chore(cardano-chain-follower): Cleanup traces and add missing docs * chore(cardano-chain-follower): Fix linter issues * chore(cardano-chain-follower): Fix formatting * chore(cardano-chain-follower): Fix spelling and cspell config * chore(cardano-chain-follower): Use pallas_hardano as a separate crate to avoid license issues * chore: Add cleanup comment to Cargo.toml * chore: Update CI files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an implementation for cardano-chain-follower crate (defined in #33).
Readercan be used to read blocks from the chain.Followershould be used to follow chain updates.