-
Notifications
You must be signed in to change notification settings - Fork 3
chore(cardano-node-follower): Crate API design #33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3acc75c to
7f69c7a
Compare
a38df14 to
73a21c9
Compare
Mr-Leshiy
reviewed
Dec 12, 2023
819dd93 to
6276275
Compare
db18905 to
1f5233a
Compare
Mr-Leshiy
approved these changes
Dec 21, 2023
Contributor
Mr-Leshiy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
29ccdb9 to
f85cb88
Compare
stevenj
approved these changes
Jan 4, 2024
Collaborator
stevenj
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
apskhem
pushed a commit
that referenced
this pull request
Jan 4, 2024
* chore: cardano-node-follower crate API design * chore: allow Blue Oak license (need for minicbor crate) * chore: drop node-to-client support and make rollback chain update return a block * feat: Add chain follower config and builder * chore: Remove chain follower crate example (hard to keep up to date) * chore: Remove chain follower struct fields (implementation specific) * feat: Add chain follower block fetch methods * chore: Add fetch block and fetch block range examples * chore: Fix lint and fmt * chore: Add chain reader struct and refactor some methods * chore: Add words to cspell project dictionary * chore: fix fmt * chore: Change read_block point type * chore: Fix lint * chore: Update rust CI version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some code to the
cardano-chain-followerthat roughly defines the crate's API. I also added some examples, which don't work because there's no implementation yet.Closes #12.