Skip to content

fix: modify the spellcheck from local to call spellcheck in catalyst-ci #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 7, 2023
Merged

fix: modify the spellcheck from local to call spellcheck in catalyst-ci #28

merged 2 commits into from
Dec 7, 2023

Conversation

@apskhem
Copy link
Collaborator

@apskhem apskhem commented Dec 7, 2023

Description

Modify the spellcheck from local to call spellcheck in catalyst-ci.

Related Issue(s)

Closes #27

Description of Changes

  • added a remote target check-spelling
  • updated catalylst-ci version for check-spelling from v2.0.9 to v2.0.10

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@apskhem apskhem added the enhancement New feature or request label Dec 7, 2023
@apskhem apskhem requested review from minikin and stevenj December 7, 2023 05:15
@apskhem apskhem self-assigned this Dec 7, 2023
@apskhem apskhem linked an issue Dec 7, 2023 that may be closed by this pull request
🛠️ [TASK] : Modify the spellcheck from local to call spellcheck in catalyst-ci #27
Closed
stevenj
stevenj approved these changes Dec 7, 2023
View reviewed changes
Copy link
Collaborator

@stevenj stevenj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stevenj stevenj merged commit 920f241 into main Dec 7, 2023
@stevenj stevenj deleted the fix/spellcheck-ci branch December 7, 2023 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stevenj stevenj stevenj approved these changes

@minikin minikin Awaiting requested review from minikin

Assignees

@apskhem apskhem

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

🛠️ [TASK] : Modify the spellcheck from local to call spellcheck in catalyst-ci

3 participants

@apskhem @stevenj