Skip to content

fix(cat-voices): no cache in after proposal submission page #2326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 39 commits into from
May 5, 2025
Merged

fix(cat-voices): no cache in after proposal submission page #2326

merged 39 commits into from
May 5, 2025

Conversation

@LynxLynxx
Copy link
Contributor

@LynxLynxx LynxLynxx commented Apr 23, 2025 •
edited by dt-iohk
Loading

Description

This PR resolves issue with cache on after proposal submission page

Related Issue(s)

Closes #2308

Description of Changes

  • adding additional logic to override cache

Breaking Changes

N/A

Screenshots

N/A

Related Pull Requests

Depends on #2386 Need to be merge first
Depends on input-output-hk/catalyst-ci#399

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@LynxLynxx LynxLynxx added draft Draft ux/ui UX/UI related issues dart Pull requests that update Dart code F14 labels Apr 23, 2025
@LynxLynxx LynxLynxx added this to the Fund14 Technical Readiness milestone Apr 23, 2025
@LynxLynxx LynxLynxx self-assigned this Apr 23, 2025
@LynxLynxx LynxLynxx moved this from New to 👀 In review in Catalyst Apr 23, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Apr 23, 2025 •
edited
Loading

✅ Test Report | ${\color{lightgreen}Pass: 715/719}$ | ${\color{red}Fail: 0/719}$ |

@LynxLynxx LynxLynxx added review me PR is ready for review and removed draft Draft labels Apr 23, 2025
@LynxLynxx LynxLynxx marked this pull request as ready for review April 23, 2025 12:41
@LynxLynxx LynxLynxx requested a review from dt-iohk April 25, 2025 10:34
@dt-iohk dt-iohk added the do not merge yet PR is not ready to be merged yet label Apr 25, 2025
@dt-iohk dt-iohk self-assigned this May 2, 2025
@dt-iohk dt-iohk removed the do not merge yet PR is not ready to be merged yet label May 2, 2025
@LynxLynxx
Merge branch 'fix/2308-cache-proposal-submission' of github.com:input…
46d9014 
…-output-hk/catalyst-voices into fix/2308-cache-proposal-submission
dt-iohk
dt-iohk reviewed May 2, 2025
View reviewed changes
@dt-iohk dt-iohk self-requested a review May 2, 2025 14:18
@damian-molinski damian-molinski mentioned this pull request May 5, 2025
Closed
2 tasks
@dt-iohk dt-iohk requested a review from damian-molinski May 5, 2025 08:08
damian-molinski
damian-molinski approved these changes May 5, 2025
View reviewed changes
Copy link
Contributor

@damian-molinski damian-molinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dt-iohk dt-iohk enabled auto-merge (squash) May 5, 2025 08:42
@dt-iohk dt-iohk merged commit 0850ac8 into main May 5, 2025
41 of 42 checks passed
@dt-iohk dt-iohk deleted the fix/2308-cache-proposal-submission branch May 5, 2025 09:32
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Catalyst May 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@damian-molinski damian-molinski damian-molinski approved these changes

@stevenj stevenj Awaiting requested review from stevenj stevenj is a code owner

@neil-iohk neil-iohk Awaiting requested review from neil-iohk neil-iohk is a code owner

@nathanbogale nathanbogale Awaiting requested review from nathanbogale nathanbogale is a code owner

@minikin minikin Awaiting requested review from minikin minikin is a code owner

@kukkok3 kukkok3 Awaiting requested review from kukkok3 kukkok3 is a code owner

@Mr-Leshiy Mr-Leshiy Awaiting requested review from Mr-Leshiy Mr-Leshiy is a code owner

@cong-or cong-or Awaiting requested review from cong-or cong-or is a code owner

@saibatizoku saibatizoku Awaiting requested review from saibatizoku saibatizoku is a code owner

@bkioshn bkioshn Awaiting requested review from bkioshn bkioshn is a code owner

@stanislav-tkach stanislav-tkach Awaiting requested review from stanislav-tkach stanislav-tkach is a code owner

@dt-iohk dt-iohk Awaiting requested review from dt-iohk dt-iohk is a code owner

Assignees

@LynxLynxx LynxLynxx

@dt-iohk dt-iohk

Labels

dart Pull requests that update Dart code F14 review me PR is ready for review ux/ui UX/UI related issues

Projects

Catalyst
Archived in project

Milestone

Fund14 Technical Readiness

Development

Successfully merging this pull request may close these issues.

[Bug]: Cache app when app is after proposal submisson

5 participants

@LynxLynxx @damian-molinski @dt-iohk @minikin