feat(YouTube/Settings): Remove quotations from proper nouns

[KobeW50]

Closes inotia00/ReVanced_Extended#2131

inotia00's TODO (after PR is merged?):

• Update string name for revanced_hide_subscriptions_channel_section to revanced_hide_subscriptions_carousel

• Update string name for revanced_return_shorts_channel_name to revanced_replace_channel_handle

[ILoveOpenSourceApplications]

And in description, instead of section everything is called sections. Similarly, rename podcast section to Explore the podcast section, capitalize first word of Chapters and Transcript sections. And change suggestions sections description to Featured places, Games and Music sections are hidden/shown.

Also @KobeW50, can you look into this comment, this comment and maybe this comment?

[KobeW50]

... And change suggestions sections description to Featured places, Games and Music sections are hidden/shown.

Should the setting title be renamed to Hide attributes sections?

Also @KobeW50, can you look into this comment, this comment and maybe this comment?

I'll implement the first one and the second part of the second one. For the 3rd one, I don't know how to reorder the settings (and I don't have the patience to).

[ILoveOpenSourceApplications]

Options with disable should also have similar descriptions like enable. Currently, Disable ambient mode description is 'Disables ambient mode` whereas it should've been Ambient mode is enabled and Ambient mode is disabled when toggled off and on respectively. Multiple such corrections are required here and there.

[KobeW50]

Options with disable should also have similar descriptions like enable. Currently, Disable ambient mode description is 'Disables ambient mode` whereas it should've been Ambient mode is enabled and Ambient mode is disabled when toggled off and on respectively. Multiple such corrections are required here and there.

Unfortunately, I don't have time to do this atm. I only opened this PR bec I knew fixing the proper nouns would be quick and simple. Please open a PR or issue for this.

[inotia00]

Maybe Hide subscriptions carousel? @inotia00 what do u think?

Yeap looks good

Also, I need to update the revanced_pref.xml if the string name (and setting name) is changed?

It is ideal to do so, but if so, it also requires updates on integrations and crowdin (because there is a change in the setting key)

I will manually change this part after the PR is merged later

[KobeW50]

I think this is ready.

Some notes:

1. This suggestion was not fully resolved, because there are still other examples of this issue outside the Ambient mode settings.

2. I messed up inotia00's commit where he added a string for when Disable ambient mode is On and Off. (IDK how GH works 🤷). I think I corrected my error in my most recent commit. In my recent commit, I also added a string for when Disable ambient mode in fullscreen is On and Off. IDK if there are now integrations and crowdin chores to do.

3. I added a small checklist for inotia00 to do in the description of this PR. Edit it as you see fit.

[KobeW50]

the on toggle Ambient mode is disabled for fullscreen as well.

It's better to specify "only". Lots of dynamic descriptions aren't pure opposites for the on/off positions.

[KobeW50]

Doesn't it already specify fullscreen, so is only actually required? Given there are only two places ambient mode is currently available.

True. But descriptions are meant to simplify things for users, and here "only" makes it explicit without making the sentence lengthy.

Also, "only" is useful because it implies that the Disable ambient mode will disable all ambient mode.

The string also had "only" before this PR so I think it should be kept.

[inotia00]

Also @inotia00, does toggling on Hide Comments section hide it in home feed as well or not?

When I checked integrations...
The first setting only hides the comments section in the player, the second setting only hides the comments section in the home feed

[inotia00]

Btw, I'm not sure whether "Ambient mode" is considered a noun. When checking https://support.google.com/youtube/answer/12827017, they have written it in running letters. So it may not need a capital A, which is why I canceled my initial statement.

Edit: Mainly because other options from the video flyout menu isn't capitalized. An example being "playback speed".

Tbh I think it is more appropriate to treat Ambient mode as a proper noun

I have never seen the word Ambient mode used by any other platform other than Google's platform (Android, YouTube, YouTube TV)

[KobeW50]

Also, "only" is useful because it implies that the Disable ambient mode will disable all ambient mode.
The string also had "only" before this PR so I think it should be kept.

Now here's an example. Here also "only in home feed." could be used. But it isn't necessary as there's only one home feed. The case is same here. There's only one fullscreen (whether portrait/landscape as the toggle affects both), it isn't necessary to specify "only in fullscreen" here either.

For that case, it is more obvious that the comments section under the video player is entirely separate from the comments section in the feed. In fact, even the Hide comments section toggle doesn't hide the comments section in the feed. So adding "only" doesn't serve any benefit.

But for ambient mode, it is reasonable for users to think that ambient mode in fullscreen is highly correlated to ambient mode below the player. The fact that the Disable ambient mode toggle disables ambient mode in both places is evidence of this correlation. So "only" is used to explicitly separate them.

[KobeW50]

sigh whatever you say :)

It's arbitrary at the end of the day.

[inotia00]

Is it okay to merge?

[inotia00]

I have to release a new patch, so I'll merge the changes so far

[KobeW50]

Sorry, i wasn't able to respond. Yeah, there aren't any more changes to be made regarding this PR