feat(YouTube/Settings): Remove quotations from proper nouns (#56)

* YTM: Remove quotations from proper nouns

* YT: Remove quotations from proper nouns

* Apply changes from review

* Update strings.xml

* Update strings.xml

* Speed overlay setting description

* Update strings.xml

* Rename toggle

* Revert string name change

This partially reverts commit 0005443.

* Apply suggestion from review (Hide subscriptions channel section)

* Apply suggestion from review

* Unfuck my forced commit mess

(Also made another description dynamic)

* Apply suggestion from review

* capitalize `Ambient mode` and change wording

* Apply code review suggestions

* Apply suggestion from review

---------

Co-authored-by: inotia00 <108592928+inotia00@users.noreply.github.com>

src/main/kotlin/app/revanced/patches/youtube/layout/doubletaplength/DoubleTapLengthPatch.kt

@@ -14,15 +14,15 @@ import java.nio.file.Files
 @Suppress("DEPRECATION", "unused")
 object DoubleTapLengthPatch : BaseResourcePatch(
     name = "Custom double tap length",
-    description = "Adds 'double-tap to seek' values that are specified in options.json.",
+    description = "Adds Double-tap to seek values that are specified in options.json.",
     dependencies = setOf(SettingsPatch::class),
     compatiblePackages = COMPATIBLE_PACKAGE
 ) {
     private val DoubleTapLengthArrays by stringPatchOption(
         key = "DoubleTapLengthArrays",
         default = "3, 5, 10, 15, 20, 30, 60, 120, 180",
-        title = "Double-tap to seek Values",
-        description = "A list of custom double-tap to seek lengths to be added, separated by commas.",
+        title = "Double-tap to seek values",
+        description = "A list of custom Double-tap to seek lengths to be added, separated by commas.",
         required = true
     )
 

src/main/kotlin/app/revanced/patches/youtube/player/ambientmode/AmbientModeSwitchPatch.kt

@@ -25,7 +25,7 @@ import com.android.tools.smali.dexlib2.iface.reference.MethodReference
 @Suppress("unused")
 object AmbientModeSwitchPatch : BaseBytecodePatch(
     name = "Ambient mode control",
-    description = "Adds options to disable ambient mode and to bypass ambient mode restrictions.",
+    description = "Adds options to disable Ambient mode and to bypass Ambient mode restrictions.",
     dependencies = setOf(SettingsPatch::class),
     compatiblePackages = COMPATIBLE_PACKAGE,
     fingerprints = setOf(

src/main/resources/music/settings/host/values/strings.xml

@@ -167,8 +167,8 @@ Info:
     <string name="revanced_hide_category_bar_summary">Hides the category bar.</string>
     <string name="revanced_hide_floating_button_title">Hide floating button</string>
     <string name="revanced_hide_floating_button_summary">Hides the floating button in the Library tab.</string>
-    <string name="revanced_hide_tap_to_update_button_title">Hide \'Tap to update\' button</string>
-    <string name="revanced_hide_tap_to_update_button_summary">Hides the \'Tap to update\' button.</string>
+    <string name="revanced_hide_tap_to_update_button_title">Hide Tap to update button</string>
+    <string name="revanced_hide_tap_to_update_button_summary">Hides the Tap to update button.</string>
     <string name="revanced_hide_history_button_title">Hide History button</string>
     <string name="revanced_hide_history_button_summary">Hides the History button in the toolbar.</string>
     <string name="revanced_hide_notification_button_title">Hide Notifications button</string>
@@ -310,7 +310,7 @@ Some features may not work properly in the old player layout."</string>
     <string name="revanced_sb_segments_sponsor">Sponsor</string>
     <string name="revanced_sb_segments_sponsor_sum">Paid promotion, paid referrals, and direct advertisements. Not for self-promotion or free shout-outs to causes / creators / websites / products they like.</string>
     <string name="revanced_sb_segments_selfpromo">Unpaid / Self Promotion</string>
-    <string name="revanced_sb_segments_selfpromo_sum">Similar to \'Sponsor\' except for unpaid or self promotion. Includes sections about merchandise, donations, or information about who they collaborated with.</string>
+    <string name="revanced_sb_segments_selfpromo_sum">Similar to Sponsor, except for unpaid or self promotion. Includes sections about merchandise, donations, or information about who they collaborated with.</string>
     <string name="revanced_sb_segments_interaction">Interaction Reminder (Subscribe)</string>
     <string name="revanced_sb_segments_interaction_sum">A short reminder to like, subscribe, or follow them in the middle of content. If it is long or about something specific, it should instead be under self promotion.</string>
     <string name="revanced_sb_segments_intro">Intermission / Intro Animation</string>
@@ -375,7 +375,7 @@ Info:
     <string name="gms_core_dialog_title">Action needed</string>
     <string name="gms_core_dialog_not_whitelisted_not_allowed_in_background_message">"GmsCore does not have permission to run in the background.
 
-Follow the 'Don't kill my app!' guide for your device, and apply the instructions to your GmsCore installation.
+Follow the Don't kill my app! guide for your device, and apply the instructions to your GmsCore installation.
 
 This is required for the app to work."</string>
     <string name="gms_core_dialog_open_website_text">Open website</string>