Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(YouTube/Change start page): change the actual start page instead of redirecting the Url #2395

Closed
5 tasks done
inotia00 opened this issue Sep 18, 2024 · 4 comments
Closed
5 tasks done
Labels
Feature request Requesting a new feature

Comments

@inotia00
Copy link
Owner

inotia00 commented Sep 18, 2024

Application

YouTube

Feature description

This is not a patch request, but a description of the feature that will be introduce in the next release.

The Change start page patch implemented in YouTube does not change the actual start page

It opens the start page Url as soon as the home feed is opened

Therefore, the following issues have been raised:

  1. The user sets the start page to Library and opens YouTube
  2. The Library tab is opened (root tab is the home feed)
  3. When the back button is clicked on the Library tab, the home feed appears instead of exiting the app

The Change start page patch implemented in YouTube Music overrides the browseId

Since the patch changes the root tab, clicking the back button exits the app instead of returning to the home feed

Just like in YouTube Music, we need to override the browseId in YouTube as well

Motivation

  1. This suggestion is more consistent with the patch description
  2. If this suggestion is applied, the patch will no longer depend on Shell_HomeActivity, so it can be used regardless of YouTube version

Acknowledgements

  • This is not a feature request for YouTube.
  • This issue is not a duplicate of an existing feature request.
  • I have chosen an appropriate title.
  • All requested information has been provided properly.
  • I have written the title and contents in English.
@inotia00 inotia00 added the Feature request Requesting a new feature label Sep 18, 2024
inotia00 added a commit to inotia00/revanced-integrations that referenced this issue Sep 18, 2024
inotia00 added a commit to inotia00/revanced-patches that referenced this issue Sep 18, 2024
@ghost
Copy link

ghost commented Sep 23, 2024

Hmm, my start page is set to Search, if I use previous key it goes to homepage instead of exiting the app.

@inotia00
Copy link
Owner Author

For some special pages like Search, Liked video, Watch later, due to limitations of YouTube API, parent browseId cannot be overridden
(Forcing override causes bug)

For these special pages, fall back to the default home feed to avoid bugs

@ghost
Copy link

ghost commented Sep 23, 2024

For some special pages like Search, Liked video, Watch later, due to limitations of YouTube API, parent browseId cannot be overridden (Forcing override causes bug)

For these special pages, fall back to the default home feed to avoid bugs

Can you add a small disclaimer under the Start Page setting stating this?

@inotia00
Copy link
Owner Author

reflected in revanced-patches-4.14.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature request Requesting a new feature
Projects
None yet
Development

No branches or pull requests

1 participant