feat(YouTube): Support versions `19.25` and `19.34` #3629

zainarbani · 2024-09-07T22:40:47Z

Adds support for versions 19.25.38 and 19.34.42

The recommended app version is still 19.16.39

Because of the possibility of unidentified issues and the lack of Restore old seekbar thumbnails support, the recommended app version is still 19.16.39

Bugs, stability

The recent versions of YouTube have many A/B tests. Both of these new versions may experience more bugs and partially broken patch features. It's also possible you may encounter unidentified ads compared to using 19.16.39.

Seekbar thumbnails

Restore old seekbar thumbnails is not supported on any version after 19.16.39. The code for the old style thumbnails is no longer present and there is no way to restore. If you want the old seekbar thumbnails then continue patching 19.16.39.

Miniplayer

The modern miniplayers are still under development by YouTube, and as such there can be bugs and issues while using them.

The later targets both add and remove some miniplayer features.

19.25.37 adds miniplayer drag and drop and double tap and pinch to increase the miniplayer size. It's also the last version that can expand/close the miniplayer by swiping (both drag and drop and double tap must be turned off), and it's the last version with 5 second skip forward/back buttons on Modern 1.
19.34.42 The initial miniplayer size can be specified in the settings. Pinch to resize is always on.

Integration changes

…ilar to `iOS` and `Android VR`

…spoof-stream

LisoUseInAIKyrios · 2024-09-07T22:58:23Z

All patches are version bumped, except for Restore old seekbar thumbnails?

The YT code for old seekbar thumbnails is removed after 19.16, so there's no way a patch can force it on.

Do any versions between 19.16 and 19.31 also work?

LisoUseInAIKyrios · 2024-09-07T23:03:18Z

Since old seekbar patch will remain at 19.16, that means the recommended version will still show as 19.16, but I think for now that is good.

There is many changes and so many a/b tests in the recent YT versions that it's almost certain some users will experience half broke patch functionality or run into new annoying content that has no removal patch. So it's better to recommending 19.16 unless a user wants to opt in to brave patching the latest.

…is merged

src/main/kotlin/app/revanced/patches/youtube/misc/litho/filter/LithoFilterPatch.kt

…h 19.31

oSumAtrIX · 2024-10-19T05:12:22Z

The PR looks ready to me. There are only nitpicks left (and the remaining reviews). I'd probably leave using a more deep review, but they don't block the PR. So far no issues testing it too.

LisoUseInAIKyrios · 2024-10-19T07:23:17Z

There's an issue with the background playback video id hook no longer working. At least, it's not working with 19.42.

It breaks voting for Shorts since it doesn't know what the current video is.

Edit: it was the background playback change for 19.41. It needs adjustments to work correctly.
Reverting the change and it works correctly again now.

Edit 2: Issue is fixed with 19.41+

This reverts commit 483f948.

…. No reason to keep it when 19.49 and 19.16 are better choices..

# [4.17.0-dev.11](v4.17.0-dev.10...v4.17.0-dev.11) (2024-10-19) ### Features * **YouTube:** Support versions `19.25` and `19.34` ([#3629](#3629)) ([049e7f0](049e7f0))

oSumAtrIX · 2024-10-19T12:55:47Z

Thanks for everyone involved in this PR!

# [4.17.0](v4.16.0...v4.17.0) (2024-10-20) ### Bug Fixes * **Twitter - Unlock downloads:** Make it work with latest versions ([#3782](#3782)) ([5189122](5189122)) * **YouTube - GmsCore support:** Add more replacements ([4d39770](4d39770)) * **YouTube - GmsCore support:** Remove unclear patch changes ([021d858](021d858)) * **YouTube - Hide layout components:** Adjust settings text ([#3745](#3745)) ([13998bb](13998bb)) * **YouTube - Spoof video streams:** Fix playback for Android VR by removing invalid body as well ([#3769](#3769)) ([5150a15](5150a15)) ### Features * **Backdrops - Pro unlock:** Support latest versions by removing version constraint ([a62b506](a62b506)) * **Facebook:** Add `Hide sponsored stories` patch ([#3627](#3627)) ([214c72b](214c72b)) * **Sync for Reddit:** Add `Fix video downloads` patch ([#3739](#3739)) ([a47ee38](a47ee38)) * **Twitter:** Add `Change link sharing domain` patch ([#3753](#3753)) ([9269a07](9269a07)) * **Willhaben:** Add `Hide ads` patch ([#3740](#3740)) ([1fe3a52](1fe3a52)) * **YouTube - Hide layout components:** Add option to hide Yoodles (YouTube Doodles) ([#3743](#3743)) ([b8c8916](b8c8916)) * **YouTube - Hide Shorts components:** Add option to hide `Use template`, `Upcoming`, `Green screen` buttons ([#3752](#3752)) ([f71c406](f71c406)) * **YouTube - Hide Shorts components:** Add option to hide like fountain ([#3731](#3731)) ([00a99dd](00a99dd)) * **YouTube - Hide Shorts components:** Hide `Hashtag` button ([#3787](#3787)) ([828a634](828a634)) * **YouTube:** Support versions `19.25` and `19.34` ([#3629](#3629)) ([049e7f0](049e7f0)) ### Performance Improvements * **YouTube - GmsCore support:** Improve performance by using hashsets ([2c5d390](2c5d390))

# [4.17.0](v4.16.0...v4.17.0) (2024-10-20) ### Bug Fixes * **Twitter - Unlock downloads:** Make it work with latest versions ([ReVanced#3782](https://github.com/E85Addict/revanced-patches/issues/3782)) ([5189122](5189122)) * **YouTube - GmsCore support:** Add more replacements ([4d39770](4d39770)) * **YouTube - GmsCore support:** Remove unclear patch changes ([021d858](021d858)) * **YouTube - Hide layout components:** Adjust settings text ([ReVanced#3745](https://github.com/E85Addict/revanced-patches/issues/3745)) ([13998bb](13998bb)) * **YouTube - Spoof video streams:** Fix playback for Android VR by removing invalid body as well ([ReVanced#3769](https://github.com/E85Addict/revanced-patches/issues/3769)) ([5150a15](5150a15)) ### Features * **Backdrops - Pro unlock:** Support latest versions by removing version constraint ([a62b506](a62b506)) * **Facebook:** Add `Hide sponsored stories` patch ([ReVanced#3627](https://github.com/E85Addict/revanced-patches/issues/3627)) ([214c72b](214c72b)) * **Sync for Reddit:** Add `Fix video downloads` patch ([ReVanced#3739](https://github.com/E85Addict/revanced-patches/issues/3739)) ([a47ee38](a47ee38)) * **Twitter:** Add `Change link sharing domain` patch ([ReVanced#3753](https://github.com/E85Addict/revanced-patches/issues/3753)) ([9269a07](9269a07)) * **Willhaben:** Add `Hide ads` patch ([ReVanced#3740](https://github.com/E85Addict/revanced-patches/issues/3740)) ([1fe3a52](1fe3a52)) * **YouTube - Hide layout components:** Add option to hide Yoodles (YouTube Doodles) ([ReVanced#3743](https://github.com/E85Addict/revanced-patches/issues/3743)) ([b8c8916](b8c8916)) * **YouTube - Hide Shorts components:** Add option to hide `Use template`, `Upcoming`, `Green screen` buttons ([ReVanced#3752](https://github.com/E85Addict/revanced-patches/issues/3752)) ([f71c406](f71c406)) * **YouTube - Hide Shorts components:** Add option to hide like fountain ([ReVanced#3731](https://github.com/E85Addict/revanced-patches/issues/3731)) ([00a99dd](00a99dd)) * **YouTube - Hide Shorts components:** Hide `Hashtag` button ([ReVanced#3787](https://github.com/E85Addict/revanced-patches/issues/3787)) ([828a634](828a634)) * **YouTube:** Support versions `19.25` and `19.34` ([ReVanced#3629](https://github.com/E85Addict/revanced-patches/issues/3629)) ([049e7f0](049e7f0)) ### Performance Improvements * Personal Logo && Add upstream sync ([2ee2b2e](2ee2b2e)) * **YouTube - GmsCore support:** Improve performance by using hashsets ([2c5d390](2c5d390))

# [4.17.0](v4.16.0...v4.17.0) (2024-10-20) ### Bug Fixes * **Twitter - Unlock downloads:** Make it work with latest versions ([ReVanced#3782](https://github.com/E85Addicts/revanced-patches/issues/3782)) ([5189122](5189122)) * **YouTube - GmsCore support:** Add more replacements ([4d39770](4d39770)) * **YouTube - GmsCore support:** Remove unclear patch changes ([021d858](021d858)) * **YouTube - Hide layout components:** Adjust settings text ([ReVanced#3745](https://github.com/E85Addicts/revanced-patches/issues/3745)) ([13998bb](13998bb)) * **YouTube - Spoof video streams:** Fix playback for Android VR by removing invalid body as well ([ReVanced#3769](https://github.com/E85Addicts/revanced-patches/issues/3769)) ([5150a15](5150a15)) ### Features * **Backdrops - Pro unlock:** Support latest versions by removing version constraint ([a62b506](a62b506)) * **Facebook:** Add `Hide sponsored stories` patch ([ReVanced#3627](https://github.com/E85Addicts/revanced-patches/issues/3627)) ([214c72b](214c72b)) * **Instagram:** Added few patches ([f0b0451](f0b0451)) * **Sync for Reddit:** Add `Fix video downloads` patch ([ReVanced#3739](https://github.com/E85Addicts/revanced-patches/issues/3739)) ([a47ee38](a47ee38)) * **Twitter:** Add `Change link sharing domain` patch ([ReVanced#3753](https://github.com/E85Addicts/revanced-patches/issues/3753)) ([9269a07](9269a07)) * **Willhaben:** Add `Hide ads` patch ([ReVanced#3740](https://github.com/E85Addicts/revanced-patches/issues/3740)) ([1fe3a52](1fe3a52)) * **YouTube - Hide layout components:** Add option to hide Yoodles (YouTube Doodles) ([ReVanced#3743](https://github.com/E85Addicts/revanced-patches/issues/3743)) ([b8c8916](b8c8916)) * **YouTube - Hide Shorts components:** Add option to hide `Use template`, `Upcoming`, `Green screen` buttons ([ReVanced#3752](https://github.com/E85Addicts/revanced-patches/issues/3752)) ([f71c406](f71c406)) * **YouTube - Hide Shorts components:** Add option to hide like fountain ([ReVanced#3731](https://github.com/E85Addicts/revanced-patches/issues/3731)) ([00a99dd](00a99dd)) * **YouTube - Hide Shorts components:** Hide `Hashtag` button ([ReVanced#3787](https://github.com/E85Addicts/revanced-patches/issues/3787)) ([828a634](828a634)) * **YouTube:** Support versions `19.25` and `19.34` ([ReVanced#3629](https://github.com/E85Addicts/revanced-patches/issues/3629)) ([049e7f0](049e7f0)) ### Performance Improvements * **YouTube - GmsCore support:** Improve performance by using hashsets ([2c5d390](2c5d390))

LisoUseInAIKyrios · 2024-11-02T20:06:48Z

@0xrxL Can you still reproduce the null litho path issue on your account?

I found some feature flags that toggle some new native code for litho and the protobuf. If I force one flag on then the litho path is missing, and if I force another flag then the protobuffer is always empty (since it's then handled by native non java code).

But I'm unsure if forcing these flags off will always work, because if there is other flags that control related code and forcing only some off may crash the app.

0xrxL · 2024-11-02T20:11:08Z

@0xrxL Can you still reproduce the null litho path issue on your account?

I found some feature flags that toggle some new native code for litho and the protobuf. If I force one flag on then the litho path is missing, and if I force another flag then the protobuffer is always empty (since it's then handled by native non java code).

But I'm unsure if forcing these flags off will always work, because if there is other flags that control related code and forcing only some off may crash the app.

Nope, I don't have this A/B test enabled anymore from 19.42 version. In fact I'm switched back to my main account.

In any case you can ask to @MarcaDian, the last time he said that was still able to reproduce this on 19.41.

0xrxL · 2024-11-02T20:18:04Z

@LisoUseInAIKyrios

P.S: About litho: did you do a filters cleanup? I do it yesterday on my side, and I removed at least 20 of them inherited from 2 years old YouTube versions (included some patches related to no more visible ads and info cards, fully migrated to litho format).

LisoUseInAIKyrios · 2024-11-02T20:20:49Z

Nobody has bothered to cleanup any old stale litho filters.

It's difficult to figure out which ones are still in use and which are obsolete.

MarcaDian · 2024-11-02T20:39:47Z

I found some feature flags that toggle some new native code for litho and the protobuf. If I force one flag on then the litho path is missing, and if I force another flag then the protobuffer is always empty (since it's then handled by native non java code).

Can you make these changes in your repo? I want to try as I am interested in versions higher than 19.40

LisoUseInAIKyrios · 2024-11-02T21:21:38Z

I'm making a pull request now.

I think this should allow adding 19.43, since everything was already working and it was these nasty litho issues that preventing going higher than 19.34.

zainarbani and others added 14 commits August 24, 2024 11:43

fix(YouTube - Spoof Client): Fix playback by replace streaming data

70bdc0d

Merge branch 'dev' into fix/yt-spoof-stream

ceced62

Add iOS client as streaming data source

d2c0a1c

refactor: Present stream replacement in the settings as an option sim…

f5a283f

…ilar to `iOS` and `Android VR`

fix: Remove client type spoofing and use only stream replacement

5860bcb

Fix: Remove obsolete code that no longer works

23b0d7b

refactor: Comments, rename repurposed code

f7dcb59

fix: Can use non experimental parent class type

26733c8

Don't block /get_watch

4ccfdf4

Merge remote-tracking branch 'refs/remotes/upstream/dev' into fix/yt-…

fe2634e

…spoof-stream

fix: Constrain to working versions

20a7ade

Revert "Don't block /get_watch"

6513909

Merge remote-tracking branch 'refs/remotes/upstream/dev' into fix/yt-…

08eea0b

…spoof-stream

feat(YouTube): Support version ~19.31

aad5e50

zainarbani mentioned this pull request Sep 7, 2024

feat(YouTube): Support versions 19.25 and 19.34 ReVanced/revanced-integrations#689

Merged

This comment was marked as resolved.

Sign in to view

This comment was marked as outdated.

Sign in to view

fix: temporarily ignore broken client-spoof until stream replacement …

3073fd3

…is merged

LisoUseInAIKyrios force-pushed the feat/yt-bump branch from 52cb281 to 3073fd3 Compare September 8, 2024 01:12

LisoUseInAIKyrios reviewed Sep 8, 2024

View reviewed changes

src/main/kotlin/app/revanced/patches/youtube/misc/litho/filter/LithoFilterPatch.kt Outdated Show resolved Hide resolved

This comment was marked as resolved.

Sign in to view

LisoUseInAIKyrios added 2 commits September 7, 2024 22:56

fix compiler warnings

f7b066f

fix: Use version 19.30.39 instead, just to avoid Miniplayer issue wit…

40ede12

…h 19.31

LisoUseInAIKyrios changed the title ~~feat(YouTube): Support version ~19.31~~ feat(YouTube): Support version ~19.30 Sep 8, 2024

This comment was marked as resolved.

Sign in to view

LisoUseInAIKyrios added 2 commits October 19, 2024 00:59

refactor: Use utility method

62f5356

refactor: Use utility method

ef5eb82

oSumAtrIX approved these changes Oct 19, 2024

View reviewed changes

LisoUseInAIKyrios added 3 commits October 19, 2024 01:14

Comments

5ce840a

fix: Use add instructions with label

1ee0fc5

Comment

8ea4839

LisoUseInAIKyrios added 4 commits October 19, 2024 03:31

Revert "fix: Unofficial support for 19.41.39"

47bbfe5

This reverts commit 483f948.

fix video id hook with 19.41+

d1b23ac

fix: 19.05 has a YouTube bug where on first load the layout is broken…

405508e

…. No reason to keep it when 19.49 and 19.16 are better choices..

Miniplayer: Adjust settings text

a401e2c

LisoUseInAIKyrios force-pushed the feat/yt-bump branch from 2538dec to a401e2c Compare October 19, 2024 09:17

LisoUseInAIKyrios added 5 commits October 19, 2024 05:40

fix(Miniplayer): Adjust settings order

85a35cf

refactor: Cleanup and use of newer and simpler utility methods

01adee0

refactor: Use correct variable name

5c6a903

refactor

6a8da9b

refactor

a792c40

LisoUseInAIKyrios merged commit 049e7f0 into ReVanced:dev Oct 19, 2024
1 check passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(YouTube): Support versions `19.25` and `19.34` #3629

feat(YouTube): Support versions `19.25` and `19.34` #3629

zainarbani commented Sep 7, 2024 •

edited by LisoUseInAIKyrios

Loading

LisoUseInAIKyrios commented Sep 7, 2024

LisoUseInAIKyrios commented Sep 7, 2024 •

edited

Loading

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as outdated.

This comment was marked as resolved.

This comment was marked as resolved.

oSumAtrIX commented Oct 19, 2024 •

edited

Loading

LisoUseInAIKyrios commented Oct 19, 2024 •

edited

Loading

oSumAtrIX commented Oct 19, 2024

LisoUseInAIKyrios commented Nov 2, 2024

0xrxL commented Nov 2, 2024

0xrxL commented Nov 2, 2024

LisoUseInAIKyrios commented Nov 2, 2024

MarcaDian commented Nov 2, 2024

LisoUseInAIKyrios commented Nov 2, 2024

feat(YouTube): Support versions 19.25 and 19.34 #3629

feat(YouTube): Support versions 19.25 and 19.34 #3629

Conversation

zainarbani commented Sep 7, 2024 • edited by LisoUseInAIKyrios Loading

The recommended app version is still 19.16.39

Bugs, stability

Seekbar thumbnails

Miniplayer

LisoUseInAIKyrios commented Sep 7, 2024

LisoUseInAIKyrios commented Sep 7, 2024 • edited Loading

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as outdated.

This comment was marked as resolved.

This comment was marked as resolved.

oSumAtrIX commented Oct 19, 2024 • edited Loading

LisoUseInAIKyrios commented Oct 19, 2024 • edited Loading

oSumAtrIX commented Oct 19, 2024

LisoUseInAIKyrios commented Nov 2, 2024

0xrxL commented Nov 2, 2024

0xrxL commented Nov 2, 2024

LisoUseInAIKyrios commented Nov 2, 2024

MarcaDian commented Nov 2, 2024

LisoUseInAIKyrios commented Nov 2, 2024

feat(YouTube): Support versions `19.25` and `19.34` #3629

feat(YouTube): Support versions `19.25` and `19.34` #3629

zainarbani commented Sep 7, 2024 •

edited by LisoUseInAIKyrios

Loading

LisoUseInAIKyrios commented Sep 7, 2024 •

edited

Loading

oSumAtrIX commented Oct 19, 2024 •

edited

Loading

LisoUseInAIKyrios commented Oct 19, 2024 •

edited

Loading