Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(YouTube/Spoof client): partial fix for watch history issue of brand accounts on iOS clients #2297

Closed
5 tasks done
inotia00 opened this issue Aug 4, 2024 · 6 comments
Closed
5 tasks done
Labels
Feature request Requesting a new feature

Comments

@inotia00
Copy link
Owner

inotia00 commented Aug 4, 2024

Application

YouTube

Feature description

This is not a patch request, but a description of the feature that will be introduce in the next release.

Watch history does not work on brand accounts when spoofing with iOS clients.

I've been tracking this known issue for a long time and found out that SmartTubeNext can force the generation of Watch history.

(This is invoked by the TrackingService class in the MediaServiceCore library.)

Of course, it is impossible to directly apply the method of SmartTubeNext, which is a completely different client, to ReVanced, but it seems possible to apply it to ReVanced with restrictions.

If this is implemented in ReVanced, there are the following limitations:

  1. Watch history for brand accounts only works on YouTube 18.38.45 or earlier.
  2. The last watched time is not saved. (I haven't implemented this in the patch yet.)

Motivation

Although there are many prerequisites, it may be useful for someone.

Acknowledgements

  • This is not a feature request for YouTube.
  • This issue is not a duplicate of an existing feature request.
  • I have chosen an appropriate title.
  • All requested information has been provided properly.
  • I have written the title and contents in English.
@inotia00 inotia00 added the Feature request Requesting a new feature label Aug 4, 2024
@KobeW50
Copy link
Contributor

KobeW50 commented Aug 4, 2024

Watch history for brand accounts only works on YouTube 18.38.45 or earlier.

Will this work when spoofed to this version or earlier (via the spoof app version patch)?

@inotia00
Copy link
Owner Author

inotia00 commented Aug 4, 2024

Will this work when spoofed to this version or earlier (via the spoof app version patch)?

This fix doesn't work with Spoof app version

It seems to be related to the YouTube API response changing in YouTube versions after 18.38.45

@0xrxL
Copy link

0xrxL commented Aug 4, 2024

What is the goal of this issue tracking? Improve the already existing patch by ReVanced?

@inotia00
Copy link
Owner Author

inotia00 commented Aug 4, 2024

What is the goal of this issue tracking? Improve the already existing patch by ReVanced?

ReVanced doesn't fix brand account's watch history issues

See #2290 (comment) and #2290 (comment)

inotia00 added a commit to inotia00/revanced-patches that referenced this issue Aug 4, 2024
inotia00 added a commit to inotia00/revanced-integrations that referenced this issue Aug 4, 2024
@0xrxL
Copy link

0xrxL commented Aug 4, 2024

Then the title of ReVanced's PR is wrong. 🤔

@inotia00
Copy link
Owner Author

inotia00 commented Aug 7, 2024

reflected in revanced-patches-4.12.1

@inotia00 inotia00 closed this as completed Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature request Requesting a new feature
Projects
None yet
Development

No branches or pull requests

3 participants