Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(YouTube/Spoof client): fix background playback issue with livestream on iOS clients #2290

Closed
5 tasks done
inotia00 opened this issue Aug 3, 2024 · 7 comments
Closed
5 tasks done
Labels
Feature request Requesting a new feature

Comments

@inotia00
Copy link
Owner

inotia00 commented Aug 3, 2024

Application

YouTube

Feature description

This is not a patch request, but a description of the feature that will be introduce in the next release.

Background playback does not work on livestreams when spoofing with iOS clients.

This is a known issue, and a commit (selectively spoof client for general video/livestreams/Shorts/fallback) was added as a temporary workaround for this.

Luckily I found a method to force-enable background playback, which may be a valid workaround for the background playback issue with livestream on iOS clients.

One problem is that this fix only works if the Remove background playback restrictions patch is included.

Accordingly, the Remove background playback restrictions patch will be added as a dependency of the Spoof client patch.

Motivation

The iOS client has the least side effects.

To use the iOS client as the default, I need to fix the remaining side effects as much as possible.

Acknowledgements

  • This is not a feature request for YouTube.
  • This issue is not a duplicate of an existing feature request.
  • I have chosen an appropriate title.
  • All requested information has been provided properly.
  • I have written the title and contents in English.
@inotia00 inotia00 added the Feature request Requesting a new feature label Aug 3, 2024
@ghost
Copy link

ghost commented Aug 3, 2024

ReVanced/revanced-patches#3480
If the above bug fix also are merged, all side effects of iOS clients have been practically resolved. However, I know that iOS clients do not support the OPUS codec. Is there nevertheless a way to apply the OPUS codec?

@inotia00
Copy link
Owner Author

inotia00 commented Aug 3, 2024

ReVanced/revanced-patches#3480

That PR doesn't resolve the watch history issue on the brand account

It does the same thing as the Watch history patch implemented in RVX #2275

However, I know that iOS clients do not support the OPUS codec. Is there nevertheless a way to apply the OPUS codec?

The response of the audio codec depends on the response of the video codec yt-dlp/yt-dlp#8377
(i.e. it is not possible)

@ghost
Copy link

ghost commented Aug 3, 2024

That PR doesn't resolve the watch history issue on the brand account

I thought it was because it appeared to have been resolved here. Am I wrong?

(i.e. it is not possible)

Then it would be good if you added it to the side effects. Thanks.

@inotia00
Copy link
Owner Author

inotia00 commented Aug 3, 2024

I thought it was because it appeared to have been resolved here. Am I wrong?

Yes, watch history issue for brand accounts is still not resolved
It is also mentioned in the PR's comments

@ghost
Copy link

ghost commented Aug 3, 2024

Oh, I saw the PR's Comments, but I couldn't read it properly. I made a mistake.

@0xrxL
Copy link

0xrxL commented Aug 4, 2024

@inotia00
Copy link
Owner Author

inotia00 commented Aug 7, 2024

reflected in revanced-patches-4.12.1

@inotia00 inotia00 closed this as completed Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature request Requesting a new feature
Projects
None yet
Development

No branches or pull requests

2 participants