forked from substrait-io/consumer-testing
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: use correct arguments for Ibis'
*trim
expressions
This PR fixes the usage of Ibis` `*trim` functions, which do not take any arguments but always remove whitespace instead. Unfortunately, this only changes the error that is produced since `*trim` is currently translated to Substrait correctly (see ibis-project/ibis-substrait#1224). Signed-off-by: Ingo Müller <ingomueller@google.com>
- Loading branch information
1 parent
a22e7d4
commit e6c4d87
Showing
4 changed files
with
6 additions
and
6 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
...tests/functional/extension_functions/string_snapshots/IbisProducer/ltrim-ibis_outcome.txt
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
2 changes: 1 addition & 1 deletion
2
...tests/functional/extension_functions/string_snapshots/IbisProducer/rtrim-ibis_outcome.txt
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
2 changes: 1 addition & 1 deletion
2
.../tests/functional/extension_functions/string_snapshots/IbisProducer/trim-ibis_outcome.txt
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.