-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug: incorrect mapping of *strip
to *trim
#1224
Labels
bug
Something isn't working
Comments
ingomueller-net
added a commit
to ingomueller-net/substrait-consumer-testing
that referenced
this issue
Dec 11, 2024
This PR fixes the usage of Ibis` `*trim` functions, which do not take any arguments but always remove whitespace instead. Unfortunately, this only changes the error that is produced since `*trim` is currently translated to Substrait correctly (see ibis-project/ibis-substrait#1224). Signed-off-by: Ingo Müller <ingomueller@google.com>
ingomueller-net
added a commit
to ingomueller-net/substrait-consumer-testing
that referenced
this issue
Dec 11, 2024
This PR fixes the usage of Ibis` `*trim` functions, which do not take any arguments but always remove whitespace instead. Unfortunately, this only changes the error that is produced since `*trim` is currently translated to Substrait correctly (see ibis-project/ibis-substrait#1224). Signed-off-by: Ingo Müller <ingomueller@google.com>
ingomueller-net
added a commit
to ingomueller-net/substrait-consumer-testing
that referenced
this issue
Dec 11, 2024
This PR fixes the usage of Ibis` `*trim` functions, which do not take any arguments but always remove whitespace instead. Unfortunately, this only changes the error that is produced since `*trim` is currently translated to Substrait correctly (see ibis-project/ibis-substrait#1224). Signed-off-by: Ingo Müller <ingomueller@google.com>
ingomueller-net
added a commit
to substrait-io/consumer-testing
that referenced
this issue
Dec 11, 2024
This PR fixes the usage of Ibis` `*trim` functions, which do not take any arguments but always remove whitespace instead. Unfortunately, this only changes the error that is produced since `*trim` is currently translated to Substrait correctly (see ibis-project/ibis-substrait#1224). Signed-off-by: Ingo Müller <ingomueller@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What happened?
Ibis'
strip
,lstrip
, andrstrip
take no additional arguments and remove whitespace; Substrait'strim
,ltrim
, andrtrim
, however, do take an additional argument, which specifies the characters that should be removed. Currently,*strip
is mapped to*trim
as is, leading to an exception because to signature of the form('str',)
is found for*trim
. Instead, we should map to a call to*trim
that builds a character set of whitespace characters.Example:
What version of ibis-substrait are you using?
ibis-framework==9.5.0
ibis-substrait==4.0.1
What substrait consumer(s) are you using, if any?
No response
Relevant log output
The text was updated successfully, but these errors were encountered: