-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make total_voting_power
optional
#1340
Make total_voting_power
optional
#1340
Conversation
total_voting_power
total_voting_power
optional
I can't explicitly request a reviewer but I'd appreciate @thanethomson 's opinion on if it makes sense to do this. |
Codecov Report
@@ Coverage Diff @@
## main #1340 +/- ##
=======================================
+ Coverage 59.3% 59.6% +0.3%
=======================================
Files 273 272 -1
Lines 27095 26929 -166
=======================================
+ Hits 16068 16071 +3
+ Misses 11027 10858 -169
... and 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Are there any updates on the review status of this PR? |
Bump to above ^ |
As we are looking closer into this change, it raises some deeper questions about the way this field is serialized. It's not a good idea to denormalize the total voting power value on the We had to skip the field to match the data where it is not present in at least one place in #1292. |
Closing to implement a proper fix for #1348. |
Motivated by celestiaorg/celestia-core#1052
I'm a Rust noob so would appreciate a thorough review and/or feedback on if this is desirable.
total_voting_power
in docs).changelog/