total_voting_power missing from RPC response

[ratankaliani]

Bug Report

While querying several Celestia testnet RPC's for the most recent signed_block, they fail to include total_voting_power within the ValidatorSet struct.

total_voting_power should be included in congruence with the protobuf specification for ValidatorSet which is one of the fields in ResultSignedBlock.

Setup

Queried several RPC's for signed_block

NodesGuru
Nodestake

What happened?

Missing total_voting_power from signed_block RPC response

What did you expect to happen?

total_voting_power that matches the sum of of all of the validators' voting power should be included in the RPC reponse inside of the validator_set struct.

How to reproduce it

Query Celestia testnet RPC's for the most recent signed_block and verify if total_voting_power is returned.

Anything else we need to know

The lack of this field means that Rust developers need to create a mirror struct that has an optional total_voting_power, as they can't use Set from tendermint-rs: https://github.com/informalsystems/tendermint-rs/blob/c2b5c9e01eab1c740598aa14375a7453f3bfa436/tendermint/src/validator.rs#L20-L24

If this is an intentional design decision to not return total_voting_power for signed blocks, a PR can be made to tendermint-rs to update the total_voting_power field of Set to be optional.

[rootulp]

Thanks for the super detailed GH issue! I don't think it's an intentional decision from Celestia to remove total_voting_power from this response. I think it's not in the RPC response b/c it's not an exported field

celestia-core/types/validator_set.go

Lines 56 to 57 in d02553f

	// cached (unexported)
	totalVotingPower int64

I verified that it's still un-exported in upstream CometBFT here so I think next steps are to learn the context of the exported field in upstream CometBFT. If we can make it public upstream, then celestia-core can pull that change.

Created cometbft/cometbft#1178

[rootulp]

Based on cometbft/cometbft#1178 it seems unlikely that upstream will export the field anytime soon so we may want to go with the alternative option you suggested:

If this is an intentional design decision to not return total_voting_power for signed blocks, a PR can be made to tendermint-rs to update the total_voting_power field of Set to be optional.

[ratankaliani]

Sounds good - thanks for opening the fix!