-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
total_voting_power
missing from RPC response
#1052
Comments
Thanks for the super detailed GH issue! I don't think it's an intentional decision from Celestia to remove celestia-core/types/validator_set.go Lines 56 to 57 in d02553f
I verified that it's still un-exported in upstream CometBFT here so I think next steps are to learn the context of the exported field in upstream CometBFT. If we can make it public upstream, then celestia-core can pull that change. Created cometbft/cometbft#1178 |
Based on cometbft/cometbft#1178 it seems unlikely that upstream will export the field anytime soon so we may want to go with the alternative option you suggested:
|
Sounds good - thanks for opening the fix! |
Bug Report
While querying several Celestia testnet RPC's for the most recent
signed_block
, they fail to includetotal_voting_power
within theValidatorSet
struct.total_voting_power
should be included in congruence with the protobuf specification forValidatorSet
which is one of the fields inResultSignedBlock
.Setup
Queried several RPC's for
signed_block
NodesGuru
Nodestake
What happened?
Missing
total_voting_power
fromsigned_block
RPC responseWhat did you expect to happen?
total_voting_power
that matches the sum of of all of the validators' voting power should be included in the RPC reponse inside of thevalidator_set
struct.How to reproduce it
Query Celestia testnet RPC's for the most recent
signed_block
and verify iftotal_voting_power
is returned.Anything else we need to know
The lack of this field means that Rust developers need to create a mirror struct that has an optional
total_voting_power
, as they can't useSet
fromtendermint-rs
: https://github.com/informalsystems/tendermint-rs/blob/c2b5c9e01eab1c740598aa14375a7453f3bfa436/tendermint/src/validator.rs#L20-L24If this is an intentional design decision to not return
total_voting_power
for signed blocks, a PR can be made totendermint-rs
to update thetotal_voting_power
field ofSet
to be optional.The text was updated successfully, but these errors were encountered: