Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

imp(Protobuf)!: alignencode{,_length_delimited}_vec with prost::Message to return Vec<u8> #1324

Merged
merged 7 commits into from
Jul 21, 2023
Merged

imp(Protobuf)!: alignencode{,_length_delimited}_vec with prost::Message to return Vec<u8> #1324

merged 7 commits into from
Jul 21, 2023

Commits on Jul 11, 2023

  1. imp: remove errors for encode{,_length_delimited}_vec methods in Prot… 

    …obuf
    @Farhad-Shabani
    Farhad-Shabani committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    cfadf71 View commit details
    Browse the repository at this point in the history

  2. chore: add component name + unclog for removing mandatory clones

    @Farhad-Shabani
    Farhad-Shabani committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    67a28a3 View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2023

  1. imp(Protobuf): remove mandatory cloning in default method impls

    @Farhad-Shabani
    Farhad-Shabani committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    c8d5fc2 View commit details
    Browse the repository at this point in the history

  2. nit: clippy catches

    @Farhad-Shabani
    Farhad-Shabani committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    a3540ae View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2023

  1. nit: to_signable_vec under vote.rs takes self and avoid clone 

    Co-authored-by: Mikhail Zabaluev <mikhail@informal.systems>
    @Farhad-Shabani @mzabaluev
    Farhad-Shabani and mzabaluev authored Jul 18, 2023
    Configuration menu
    Copy the full SHA
    81b02b3 View commit details
    Browse the repository at this point in the history

  2. nit: to_signable_vec under proposal.rs takes self and avoid clone 

    Co-authored-by: Mikhail Zabaluev <mikhail@informal.systems>
    @Farhad-Shabani @mzabaluev
    Farhad-Shabani and mzabaluev authored Jul 18, 2023
    Configuration menu
    Copy the full SHA
    52af4a8 View commit details
    Browse the repository at this point in the history

  3. fix: remove clone under SignProposal/VoteRequest as well

    @Farhad-Shabani
    Farhad-Shabani committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    039407e View commit details
    Browse the repository at this point in the history