Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

imp(Protobuf)!: alignencode{,_length_delimited}_vec with prost::Message to return Vec<u8> #1324

Merged
merged 7 commits into from
Jul 21, 2023

Conversation

Farhad-Shabani
Copy link
Member

Closes: #1323

  • Referenced an issue explaining the need for the change
  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Added entry in .changelog/

@Farhad-Shabani Farhad-Shabani marked this pull request as ready for review July 11, 2023 03:57
Copy link
Contributor

@mzabaluev mzabaluev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good, annoying unwraps gone!

proto/src/lib.rs Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Jul 12, 2023

Codecov Report

Merging #1324 (5dfc4f5) into main (9854a66) will decrease coverage by 0.1%.
The diff coverage is 93.4%.

❗ Current head 5dfc4f5 differs from pull request most recent head a3540ae. Consider uploading reports for the commit a3540ae to get more accurate results

@@           Coverage Diff           @@
##            main   #1324     +/-   ##
=======================================
- Coverage   59.7%   59.7%   -0.1%     
=======================================
  Files        283     283             
  Lines      26903   26891     -12     
=======================================
- Hits       16087   16073     -14     
- Misses     10816   10818      +2     
Impacted Files Coverage Δ
tendermint/src/proposal/sign_proposal.rs 40.5% <0.0%> (ø)
tendermint/src/proposal.rs 90.4% <33.3%> (ø)
proto/src/lib.rs 100.0% <100.0%> (ø)
proto/tests/unit.rs 94.8% <100.0%> (ø)
tendermint/src/block/header.rs 99.2% <100.0%> (-0.1%) ⬇️
tendermint/src/public_key.rs 76.3% <100.0%> (ø)
tendermint/src/public_key/pub_key_request.rs 97.3% <100.0%> (ø)
tendermint/src/validator.rs 72.6% <100.0%> (-0.4%) ⬇️
tendermint/src/vote.rs 83.5% <100.0%> (ø)
tendermint/src/vote/sign_vote.rs 96.8% <100.0%> (ø)

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@romac romac added this to the 0.33.0 milestone Jul 13, 2023
@romac romac mentioned this pull request Jul 13, 2023
3 tasks
tendermint/src/proposal.rs Outdated Show resolved Hide resolved
tendermint/src/vote.rs Outdated Show resolved Hide resolved
tendermint/src/proposal.rs Outdated Show resolved Hide resolved
@mzabaluev mzabaluev merged commit 808835a into main Jul 21, 2023
23 checks passed
@mzabaluev mzabaluev deleted the farhad/1323-encode-vec-no-err branch July 21, 2023 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove error variant of encode{,_length_delimited}_vec methods in Protobuf trait
5 participants