Corrected mismatch in config.toml comment
#2751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…value of 'clear_on_start' is 'true' and removed unused Default implementation for Packet
romac
approved these changes
Oct 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #2750
Description
This PR updates the comment in the example
config.tomlto correctly state that the default value forclear_on_startistrue.In addition the implementation of
Defaultfor the packet configuration values, structPacket, has been removed as it was unused and had different values from the default values used in theDefaultimplementation forModeConfig.PR author checklist:
unclog.Added tests: integration (for Hermes) or unit/mock tests (for modules).docs/).Reviewer checklist:
Files changedin the GitHub PR explorer.