Skip to content

Mismatch between comment and implementation for default value of clear_on_start #2750

Closed
@ljoss17

Description

@ljoss17

Summary of Bug

The comment, in example config.toml, for clear_on_start says the default value is false, while the implementation has the default value set to true.

config.toml:

hermes/config.toml

Lines 53 to 54 in c34b354

# Whether or not to clear packets on start. [Default: false]
clear_on_start = true

Implementation:

impl Default for ModeConfig {
fn default() -> Self {
Self {
clients: Clients {
enabled: true,
refresh: true,
misbehaviour: false,
},
connections: Connections { enabled: false },
channels: Channels { enabled: false },
packets: Packets {
enabled: true,
clear_interval: default::clear_packets_interval(),
clear_on_start: true,
tx_confirmation: default::tx_confirmation(),
},
}
}
}

Version

Latest commit at the moment, 20/10/22: c34b354

Acceptance Criteria

Comment and implementation default are the same


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions