Skip to content

Implement FromStr<Path> for ics24_host::Path #1460

@seanchen1991

Description

@seanchen1991

Crate

The ibc crate.

Summary

Implement FromStr<Path> for ics24_host::Path in order to facilitate deserialization in concrete Paths in basecoin-rs.

Problem Definition

As part of #14 in basecoin-rs, we're looking to add the ability to deserialize string paths into concrete Paths. While this could be done on the Basecoin side, this is functionality that others will likely find useful so well, so it makes sense to implement it in ibc-rs to reduce code duplication.

Proposal

Implement FromStr<Path>, which would essentially be doing the opposite of the Display<Path> impl.

Acceptance Criteria

Implementing of FromStr<Path> added with adequate testing coverage.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

O: new-featureObjective: cause to add a new feature or support

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions