Skip to content

Path and Identifier validation and improvements #14

Closed
@hu55a1n1

Description

@hu55a1n1

Description

  • We must also define concretely what an Identifier is and validate it in accordance with ICS024.
  • Path should ideally be a trait. Must provide methods for splitting into component Identifiers, append, etc.
  • Replace basecoin-rs/src/app/store.rs:Identifier::is_valid() with ibc-rs/modules/src/ics24_host/validate.rs:validate_identifier().
  • Reuse ibc-rs/modules/src/ics24_host/identifier.rs:{ChainId, ClientId, *} in basecoin-rs/src/app/modules/ibc.rs.
  • Deserialize paths into concrete ibc-rs/modules/src/ics24_host/path.rs:29.
  • Does it make sense to use const-generics? e.g.
pub struct Identifier<const N: usize>([char; N]);

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions