Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Path and Identifier validation and improvements #22

Merged
merged 27 commits into from
Dec 9, 2021

Conversation

seanchen1991
Copy link
Contributor

@seanchen1991 seanchen1991 commented Oct 12, 2021

Addresses the remaining tasks in #14

  • Replace basecoin-rs/src/app/store.rs:Identifier::is_valid() with ibc-rs/modules/src/ics24_host/validate.rs:validate_identifier().
  • Deserialize paths into concrete ibc-rs/modules/src/ics24_host/path.rs:29. (Implement FromStr for Path hermes#1480)
  • Does it make sense to use const-generics? e.g. (Although this will be stored on the stack, I think it increases memory usage because we're always reserving N chars. Moreover, I feel like this is something we should add to ibc-rs, so let's leave this for now.)
pub struct Identifier<const N: usize>([char; N]);

@hu55a1n1 hu55a1n1 changed the base branch from main to phase4 December 9, 2021 10:43
@hu55a1n1 hu55a1n1 marked this pull request as ready for review December 9, 2021 10:50
@hu55a1n1 hu55a1n1 changed the base branch from phase4 to main December 9, 2021 13:43
@hu55a1n1 hu55a1n1 merged commit 3350d36 into informalsystems:main Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants