-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Path and Identifier validation and improvements #22
Merged
hu55a1n1
merged 27 commits into
informalsystems:main
from
seanchen1991:path-identifier-cleanup
Dec 9, 2021
Merged
Path and Identifier validation and improvements #22
hu55a1n1
merged 27 commits into
informalsystems:main
from
seanchen1991:path-identifier-cleanup
Dec 9, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix merge conflicts.
Pull in upstream changes
Merging in upstream changes.
Merge upstream changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses the remaining tasks in #14
basecoin-rs/src/app/store.rs:Identifier::is_valid()
withibc-rs/modules/src/ics24_host/validate.rs:validate_identifier()
.ibc-rs/modules/src/ics24_host/path.rs:29
. (Implement FromStr for Path hermes#1480)Does it make sense to use const-generics? e.g.(Although this will be stored on the stack, I think it increases memory usage because we're always reservingN
chars. Moreover, I feel like this is something we should add to ibc-rs, so let's leave this for now.)