Use Systemd for Amazon Linux 2 #5387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielnelson
reviewed
Feb 6, 2019
scripts/post-install.sh
Outdated
| # Run update-rc.d or fallback to chkconfig if not available | ||
| if which update-rc.d &>/dev/null; then | ||
| install_update_rcd | ||
| if [[ $VERSION_ID = "2" ]]; then |
There was a problem hiding this comment.
I expect that when VERSION_ID=3 is released it will still be using systemd, so maybe we can have the systemd path be default and only do the other methods for VERSION_ID=1 (if there is such a variable)
There was a problem hiding this comment.
Good point, I'll switch this around.
gunnaraasen
force-pushed
the
ga-azn-linux-2
branch
2 times, most recently
from
07a5cd9
to
10125a2
Compare
|
Unfortunately, |
gunnaraasen
force-pushed
the
ga-azn-linux-2
branch
2 times, most recently
from
e85fde3
to
a9c453f
Compare
|
I cleaned up the logic a bit. This is ready to merge. |
danielnelson
reviewed
Feb 6, 2019
scripts/post-install.sh
Outdated
| @@ -88,7 +88,10 @@ elif [[ -f /etc/debian_version ]]; then | |||
| fi | |||
| elif [[ -f /etc/os-release ]]; then | |||
| source /etc/os-release | |||
| if [[ $ID = "amzn" ]]; then | |||
| if [[ $NAME = "Amazon Linux" ]]; then | |||
gunnaraasen
force-pushed
the
ga-azn-linux-2
branch
from
a9c453f
to
c55e1b5
Compare
This was referenced Feb 7, 2019
trevorwhitney
pushed a commit
to trevorwhitney/telegraf
that referenced
this pull request
Feb 14, 2019
danielnelson
pushed a commit
that referenced
this pull request
Feb 19, 2019
(cherry picked from commit 52bd698)
otherpirate
pushed a commit
to otherpirate/telegraf
that referenced
this pull request
Mar 15, 2019
otherpirate
pushed a commit
to otherpirate/telegraf
that referenced
this pull request
Mar 15, 2019
dupondje
pushed a commit
to dupondje/telegraf
that referenced
this pull request
Apr 22, 2019
bitcharmer
pushed a commit
to bitcharmer/telegraf
that referenced
this pull request
Oct 18, 2019
athoune
pushed a commit
to bearstech/telegraf
that referenced
this pull request
Apr 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Amazon Linux 2 uses systemd. This PR adds support for Amazon Linux 2 in the Telegraf
post-install.shandpost-remove.shscripts.closes #5117
Required for all PRs: