Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install Telegraf #10

Merged
merged 4 commits into from
Feb 12, 2019
Merged

Install Telegraf #10

merged 4 commits into from
Feb 12, 2019

Conversation

tonerdo
Copy link
Contributor

@tonerdo tonerdo commented Feb 11, 2019

This PR contains the install-telegraf script for installing Telegraf on Amazon Linux 2 and Ubuntu 18.04. It also contains an example AMI

Copy link
Member

@gunnaraasen gunnaraasen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A common use case for Telegraf is to be installed as the collection agent on EC2 instances for other services. Can you add a disclaimer near the top of the readme that this Telegraf AMI is only useful for standing up Telegraf to pull remote data or accept data from a remote service, e.g. connecting to a queue like Kafka/PubSub or using it as a scraper to pull prometheus metrics?

"type": "shell",
"inline": [
"DEBIAN_FRONTEND=noninteractive apt-get update -y",
"apt-get install -y sudo wget git systemd"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought systemd was the default on Ubuntu 18.04. Why install a systemd package?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is for the docker image which doesn't have systemd by default

examples/telegraf-ami/telegraf.json Outdated Show resolved Hide resolved
modules/install-telegraf/install-telegraf Show resolved Hide resolved
Copy link
Contributor

@brikis98 brikis98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, LGTM!

modules/install-telegraf/install-telegraf Outdated Show resolved Hide resolved
@tonerdo tonerdo merged commit b7f5dbf into master Feb 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants