chore: Fix linter findings for Windows (part1)

[zak-pawel]

It is only part of the bigger job: #13036
After all findings in whole project are handled for Windows, linter CI job for Windows can be enabled.

Fixes for following linters have been made:

• dogsled
• errcheck
• errname
• errorlint
• gosimple

Following findings were addressed:

plugins/inputs/execd/execd_windows.go:22:28                                    errcheck   Error return value of `osStdin.SetWriteDeadline` is not checked
plugins/inputs/execd/execd_windows.go:25:52                                    errorlint  non-wrapping format verb for fmt.Errorf. Use `%w` to format errors
plugins/inputs/execd/shim/goshim_windows.go:16:3                               gosimple   S1000: should use a simple channel send/receive instead of `select` with a single case
plugins/inputs/ping/ping_windows.go:37:38                                      errorlint  non-wrapping format verb for fmt.Errorf. Use `%w` to format errors
plugins/inputs/ping/ping_windows.go:39:38                                      errorlint  non-wrapping format verb for fmt.Errorf. Use `%w` to format errors
plugins/inputs/ping/ping_windows_test.go:121:17                                errcheck   Error return value of `acc.GatherError` is not checked
plugins/inputs/ping/ping_windows_test.go:179:17                                errcheck   Error return value of `acc.GatherError` is not checked
plugins/inputs/ping/ping_windows_test.go:240:17                                errcheck   Error return value of `acc.GatherError` is not checked
plugins/inputs/ping/ping_windows_test.go:286:17                                errcheck   Error return value of `acc.GatherError` is not checked
plugins/inputs/ping/ping_windows_test.go:334:17                                errcheck   Error return value of `acc.GatherError` is not checked
plugins/inputs/ping/ping_windows_test.go:368:17                                errcheck   Error return value of `acc.GatherError` is not checked
plugins/inputs/ping/ping_windows_test.go:76:17                                 errcheck   Error return value of `acc.GatherError` is not checked
plugins/inputs/procstat/win_service_windows.go:17:20                           errcheck   Error return value of `m.Disconnect` is not checked
plugins/inputs/procstat/win_service_windows.go:37:108                          errorlint  comparing with != will fail on wrapped errors. Use errors.Is to check for a specific error
plugins/inputs/win_eventlog/util.go:100:6                                      errorlint  comparing with == will fail on wrapped errors. Use errors.Is to check for a specific error
plugins/inputs/win_eventlog/util.go:52:27                                      errcheck   Error return value of `windows.CloseHandle` is not checked
plugins/inputs/win_eventlog/win_eventlog.go:123:7                              errorlint  comparing with == will fail on wrapped errors. Use errors.Is to check for a specific error
plugins/inputs/win_eventlog/win_eventlog.go:302:27                             errcheck   Error return value of `windows.CloseHandle` is not checked
plugins/inputs/win_eventlog/win_eventlog.go:336:6                              errorlint  comparing with == will fail on wrapped errors. Use errors.Is to check for a specific error
plugins/inputs/win_eventlog/win_eventlog.go:431:17                             errcheck   Error return value is not checked
plugins/inputs/win_eventlog/win_eventlog.go:496:19                             errorlint  comparing with != will fail on wrapped errors. Use errors.Is to check for a specific error
plugins/inputs/win_perf_counters/win_perf_counters.go:385:19                   errorlint  type assertion on error will fail on wrapped errors. Use errors.As to check for specific errors
plugins/inputs/win_perf_counters/win_perf_counters.go:469:92                   errorlint  non-wrapping format verb for fmt.Errorf. Use `%w` to format errors
plugins/inputs/win_perf_counters/win_perf_counters.go:485:92                   errorlint  non-wrapping format verb for fmt.Errorf. Use `%w` to format errors
plugins/inputs/win_perf_counters/win_perf_counters.go:558:19                   errorlint  type assertion on error will fail on wrapped errors. Use errors.As to check for specific errors
plugins/inputs/win_perf_counters/win_perf_counters_integration_test.go:110:19  errorlint  type assertion on error will fail on wrapped errors. Use errors.As to check for specific errors
plugins/inputs/win_perf_counters/win_perf_counters_test.go:34:2                dogsled    declaration has 4 blank identifiers
plugins/inputs/win_perf_counters/win_perf_counters_test.go:74:13               gosimple   S1028: should use fmt.Errorf(...) instead of errors.New(fmt.Sprintf(...))
plugins/inputs/win_services/win_services.go:122:59                             errorlint  non-wrapping format verb for fmt.Errorf. Use `%w` to format errors
plugins/inputs/win_services/win_services.go:124:24                             errcheck   Error return value of `scmgr.Disconnect` is not checked
plugins/inputs/win_services/win_services.go:164:57                             errorlint  non-wrapping format verb for fmt.Errorf. Use `%w` to format errors
plugins/inputs/win_services/win_services.go:22:6                               errname    the type name `ServiceErr` should conform to the `XxxError` format
plugins/inputs/win_services/win_services.go:33:16                              errorlint  type assertion on error will fail on wrapped errors. Use errors.As to check for specific errors
plugins/inputs/win_services/win_services_integration_test.go:23:24             errcheck   Error return value of `scmgr.Disconnect` is not checked
plugins/inputs/win_services/win_services_integration_test.go:28:18             errcheck   Error return value of `winServices.Init` is not checked
plugins/inputs/win_services/win_services_integration_test.go:43:24             errcheck   Error return value of `scmgr.Disconnect` is not checked
plugins/inputs/win_services/win_services_integration_test.go:48:18             errcheck   Error return value of `winServices.Init` is not checked
plugins/inputs/win_services/win_services_integration_test.go:63:9              errcheck   Error return value of `ws.Init` is not checked
plugins/inputs/win_services/win_services_test.go:158:18                        errcheck   Error return value of `winServices.Init` is not checked
plugins/inputs/win_services/win_services_test.go:173:18                        errcheck   Error return value of `winServices.Init` is not checked
plugins/inputs/win_services/win_services_test.go:201:18                        errcheck   Error return value of `winServices.Init` is not checked
plugins/inputs/win_services/win_services_test.go:223:18                        errcheck   Error return value of `winServices.Init` is not checked
plugins/inputs/win_wmi/win_wmi.go:113:14                                       errorlint  type assertion on error will fail on wrapped errors. Use errors.As to check for specific errors
plugins/inputs/win_wmi/win_wmi.go:141:24                                       errcheck   Error return value of `serviceRaw.Clear` is not checked
plugins/inputs/win_wmi/win_wmi.go:149:23                                       errcheck   Error return value of `resultRaw.Clear` is not checked
plugins/inputs/win_wmi/win_wmi.go:171:20                                       errcheck   Error return value of `prop.Clear` is not checked
plugins/inputs/win_wmi/win_wmi.go:50:15                                        errcheck   Error return value of `v.Clear` is not checked
plugins/inputs/win_wmi/win_wmi_test.go:71:13                                   errcheck   Error return value of `plugin.Init` is not checked

[srebhan]

Thanks for taking a look at those issues @zak-pawel! I do have some comments.

[srebhan]

Thanks for fixing all those nasty issues @zak-pawel!

[telegraf-tiger]

Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

☺️ This pull request doesn't significantly change the Telegraf binary size (less than 1%)

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB	RPM	TAR GZ	ZIP
amd64.deb	aarch64.rpm	darwin_amd64.tar.gz	windows_amd64.zip
arm64.deb	armel.rpm	darwin_arm64.tar.gz	windows_arm64.zip
armel.deb	armv6hl.rpm	freebsd_amd64.tar.gz	windows_i386.zip
armhf.deb	i386.rpm	freebsd_armv7.tar.gz
i386.deb	ppc64le.rpm	freebsd_i386.tar.gz
mips.deb	riscv64.rpm	linux_amd64.tar.gz
mipsel.deb	s390x.rpm	linux_arm64.tar.gz
ppc64el.deb	x86_64.rpm	linux_armel.tar.gz
riscv64.deb		linux_armhf.tar.gz
s390x.deb		linux_i386.tar.gz
		linux_mips.tar.gz
		linux_mipsel.tar.gz
		linux_ppc64le.tar.gz
		linux_riscv64.tar.gz
		linux_s390x.tar.gz

[zak-pawel]

@powersj Ping :)

[powersj]

Sorry I thought I had gone through this and sure enough I opened it up to "11 / 16 files viewed"