Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linter findings for Windows should be fixed #13036

Closed
zak-pawel opened this issue Apr 5, 2023 · 1 comment · Fixed by #13599
Closed

Linter findings for Windows should be fixed #13036

zak-pawel opened this issue Apr 5, 2023 · 1 comment · Fixed by #13599
Labels
feature request Requests for new plugin and for new features to existing plugins linter

Comments

@zak-pawel
Copy link
Collaborator

Use Case

golangci-lint CI checks in Telegraf repo are by default run only for linux.
Thus a lot of issues for windows code only have accumulated over time.

Few unused... findings will be false-positives in the same way as they are for darwin: #12958
They are used for linux but not for other OSes.

Expected behavior

GOOS=windows make lint-branch should not return any issues found.

Actual behavior

GOOS=windows make lint-branch founds 360 issues.

Additional info

Current findings:

agent/agent_windows.go:7:26                                                    revive          unused-parameter: parameter 'flushRequested' seems to be unused, consider removing or renaming it as _
agent/agent_windows.go:11:34                                                   revive          unused-parameter: parameter 'flushRequested' seems to be unused, consider removing or renaming it as _
cmd/telegraf/telegraf_windows.go:78:25                                         revive          unused-parameter: parameter 's' seems to be unused, consider removing or renaming it as _
cmd/telegraf/telegraf_windows.go:90:19                                         unused          func `(*program).run` is unused
cmd/telegraf/telegraf_windows.go:97:24                                         revive          unused-parameter: parameter 's' seems to be unused, consider removing or renaming it as _
logger/event_logger.go:42:2                                                    nakedret        naked return in func `Write` with 18 lines of code
logger/event_logger.go:42:2                                                    revive          bare-return: avoid using bare returns, please add return expressions
logger/event_logger.go:49:43                                                   revive          unused-parameter: parameter 'config' seems to be unused, consider removing or renaming it as _
logger/event_logger_test.go:33                                                 lll             line is 162 characters
plugins/inputs/diskio/diskio.go:33:2                                           unused          field `infoCache` is unused
plugins/inputs/diskio/diskio_other.go:5:6                                      unused          type `diskInfoCache` is unused
plugins/inputs/ethtool/ethtool.go:43:2                                         unused          field `interfaceFilter` is unused
plugins/inputs/ethtool/ethtool.go:44:2                                         unused          field `namespaceFilter` is unused
plugins/inputs/ethtool/ethtool.go:45:2                                         unused          field `includeNamespaces` is unused
plugins/inputs/ethtool/ethtool.go:48:2                                         unused          field `command` is unused
plugins/inputs/execd/execd_windows.go:14:24                                    revive          unused-parameter: parameter 'acc' seems to be unused, consider removing or renaming it as _
plugins/inputs/execd/execd_windows.go:22:28                                    errcheck        Error return value of `osStdin.SetWriteDeadline` is not checked
plugins/inputs/execd/execd_windows.go:25:52                                    errorlint       non-wrapping format verb for fmt.Errorf. Use `%w` to format errors
plugins/inputs/execd/shim/goshim_windows.go:16:3                               gosimple        S1000: should use a simple channel send/receive instead of `select` with a single case
plugins/inputs/filecount/filesystem_helpers.go:43:6                            unused          type `fakeFileSystem` is unused
plugins/inputs/filecount/filesystem_helpers.go:47:6                            unused          type `fakeFileInfo` is unused
plugins/inputs/filecount/filesystem_helpers.go:56:23                           unused          func `fakeFileInfo.Name` is unused
plugins/inputs/filecount/filesystem_helpers.go:57:23                           unused          func `fakeFileInfo.Size` is unused
plugins/inputs/filecount/filesystem_helpers.go:58:23                           unused          func `fakeFileInfo.Mode` is unused
plugins/inputs/filecount/filesystem_helpers.go:59:23                           unused          func `fakeFileInfo.ModTime` is unused
plugins/inputs/filecount/filesystem_helpers.go:60:23                           unused          func `fakeFileInfo.IsDir` is unused
plugins/inputs/filecount/filesystem_helpers.go:61:23                           unused          func `fakeFileInfo.Sys` is unused
plugins/inputs/filecount/filesystem_helpers.go:63:25                           unused          func `fakeFileSystem.Open` is unused
plugins/inputs/filecount/filesystem_helpers.go:67:25                           unused          func `fakeFileSystem.Stat` is unused
plugins/inputs/ping/ping.go:91:6                                               unused          type `roundTripTimeStats` is unused
plugins/inputs/ping/ping.go:98:6                                               unused          type `stats` is unused
plugins/inputs/ping/ping_windows.go:37:38                                      errorlint       non-wrapping format verb for fmt.Errorf. Use `%w` to format errors
plugins/inputs/ping/ping_windows.go:39:38                                      errorlint       non-wrapping format verb for fmt.Errorf. Use `%w` to format errors
plugins/inputs/ping/ping_windows.go:88:1                                       revive          function-result-limit: maximum number of return results per function exceeded; max 3 but got 7
plugins/inputs/ping/ping_windows.go:88:1                                       revive          confusing-results: unnamed results of the same type may be confusing, consider using named results
plugins/inputs/ping/ping_windows.go:96:26                                      revive          var-declaration: should drop = 0 from declaration of var receivedReply; it is the zero value
plugins/inputs/ping/ping_windows_test.go:64:21                                 revive          unused-parameter: parameter 'binary' seems to be unused, consider removing or renaming it as _
plugins/inputs/ping/ping_windows_test.go:64:36                                 revive          unused-parameter: parameter 'timeout' seems to be unused, consider removing or renaming it as _
plugins/inputs/ping/ping_windows_test.go:64:53                                 revive          unused-parameter: parameter 'args' seems to be unused, consider removing or renaming it as _
plugins/inputs/ping/ping_windows_test.go:76:17                                 errcheck        Error return value of `acc.GatherError` is not checked
plugins/inputs/ping/ping_windows_test.go:107:26                                revive          unused-parameter: parameter 'binary' seems to be unused, consider removing or renaming it as _
plugins/inputs/ping/ping_windows_test.go:107:41                                revive          unused-parameter: parameter 'timeout' seems to be unused, consider removing or renaming it as _
plugins/inputs/ping/ping_windows_test.go:107:58                                revive          unused-parameter: parameter 'args' seems to be unused, consider removing or renaming it as _
plugins/inputs/ping/ping_windows_test.go:121:17                                errcheck        Error return value of `acc.GatherError` is not checked
plugins/inputs/ping/ping_windows_test.go:166:26                                revive          unused-parameter: parameter 'binary' seems to be unused, consider removing or renaming it as _
plugins/inputs/ping/ping_windows_test.go:166:41                                revive          unused-parameter: parameter 'timeout' seems to be unused, consider removing or renaming it as _
plugins/inputs/ping/ping_windows_test.go:166:58                                revive          unused-parameter: parameter 'args' seems to be unused, consider removing or renaming it as _
plugins/inputs/ping/ping_windows_test.go:179:17                                errcheck        Error return value of `acc.GatherError` is not checked
plugins/inputs/ping/ping_windows_test.go:227:26                                revive          unused-parameter: parameter 'binary' seems to be unused, consider removing or renaming it as _
plugins/inputs/ping/ping_windows_test.go:227:41                                revive          unused-parameter: parameter 'timeout' seems to be unused, consider removing or renaming it as _
plugins/inputs/ping/ping_windows_test.go:227:58                                revive          unused-parameter: parameter 'args' seems to be unused, consider removing or renaming it as _
plugins/inputs/ping/ping_windows_test.go:240:17                                errcheck        Error return value of `acc.GatherError` is not checked
plugins/inputs/ping/ping_windows_test.go:270:32                                revive          unused-parameter: parameter 'binary' seems to be unused, consider removing or renaming it as _
plugins/inputs/ping/ping_windows_test.go:270:47                                revive          unused-parameter: parameter 'timeout' seems to be unused, consider removing or renaming it as _
plugins/inputs/ping/ping_windows_test.go:270:64                                revive          unused-parameter: parameter 'args' seems to be unused, consider removing or renaming it as _
plugins/inputs/ping/ping_windows_test.go:286:17                                errcheck        Error return value of `acc.GatherError` is not checked
plugins/inputs/ping/ping_windows_test.go:320:27                                revive          unused-parameter: parameter 'binary' seems to be unused, consider removing or renaming it as _
plugins/inputs/ping/ping_windows_test.go:320:42                                revive          unused-parameter: parameter 'timeout' seems to be unused, consider removing or renaming it as _
plugins/inputs/ping/ping_windows_test.go:320:59                                revive          unused-parameter: parameter 'args' seems to be unused, consider removing or renaming it as _
plugins/inputs/ping/ping_windows_test.go:334:17                                errcheck        Error return value of `acc.GatherError` is not checked
plugins/inputs/ping/ping_windows_test.go:368:17                                errcheck        Error return value of `acc.GatherError` is not checked
plugins/inputs/postfix/stat_none.go:9:6                                        unused          func `statCTime` is unused
plugins/inputs/processes/processes_windows.go:19:28                            revive          unused-parameter: parameter 'acc' seems to be unused, consider removing or renaming it as _
plugins/inputs/procstat/native_finder_windows_test.go:39:2                     revive          import-shadowing: The name 'user' shadows an import name
plugins/inputs/procstat/win_service_windows.go:17:20                           errcheck        Error return value of `m.Disconnect` is not checked
plugins/inputs/procstat/win_service_windows.go:37:108                          errorlint       comparing with != will fail on wrapped errors. Use errors.Is to check for a specific error
plugins/inputs/win_eventlog/syscall_windows.go:39:2                            revive          var-naming: const EvtRenderEventXml should be EvtRenderEventXML
plugins/inputs/win_eventlog/util.go:22:44                                      revive          empty-lines: extra empty line at the start of a block
plugins/inputs/win_eventlog/util.go:47:1                                       revive          confusing-results: unnamed results of the same type may be confusing, consider using named results
plugins/inputs/win_eventlog/util.go:47:1                                       revive          function-result-limit: maximum number of return results per function exceeded; max 3 but got 4
plugins/inputs/win_eventlog/util.go:48:82                                      unconvert       unnecessary conversion
plugins/inputs/win_eventlog/util.go:52:27                                      errcheck        Error return value of `windows.CloseHandle` is not checked
plugins/inputs/win_eventlog/util.go:59:30                                      unconvert       unnecessary conversion
plugins/inputs/win_eventlog/util.go:61:17                                      unconvert       unnecessary conversion
plugins/inputs/win_eventlog/util.go:61:47                                      unconvert       unnecessary conversion
plugins/inputs/win_eventlog/util.go:100:6                                      errorlint       comparing with == will fail on wrapped errors. Use errors.Is to check for a specific error
plugins/inputs/win_eventlog/util.go:142:2                                      prealloc        Consider pre-allocating `fieldsUnique`
plugins/inputs/win_eventlog/win_eventlog.go:123:7                              errorlint       comparing with == will fail on wrapped errors. Use errors.Is to check for a specific error
plugins/inputs/win_eventlog/win_eventlog.go:302:27                             errcheck        Error return value of `windows.CloseHandle` is not checked
plugins/inputs/win_eventlog/win_eventlog.go:336:6                              errorlint       comparing with == will fail on wrapped errors. Use errors.Is to check for a specific error
plugins/inputs/win_eventlog/win_eventlog.go:406:28                             unconvert       unnecessary conversion
plugins/inputs/win_eventlog/win_eventlog.go:411:3                              nilerr          error is not nil (line 406) but it returns nil
plugins/inputs/win_eventlog/win_eventlog.go:429:3                              nilerr          error is not nil (line 427) but it returns nil
plugins/inputs/win_eventlog/win_eventlog.go:431:17                             errcheck        Error return value is not checked
plugins/inputs/win_eventlog/win_eventlog.go:496:19                             errorlint       comparing with != will fail on wrapped errors. Use errors.Is to check for a specific error
plugins/inputs/win_eventlog/zsyscall_windows.go:82:1                           revive          argument-limit: maximum number of arguments per function exceeded; max 6 but got 8
plugins/inputs/win_eventlog/zsyscall_windows.go:92:15                          staticcheck     SA1019: syscall.Syscall9 has been deprecated since Go 1.18: Use SyscallN instead. 
plugins/inputs/win_eventlog/zsyscall_windows.go:96:10                          unconvert       unnecessary conversion
plugins/inputs/win_eventlog/zsyscall_windows.go:100:10                         unconvert       unnecessary conversion
plugins/inputs/win_eventlog/zsyscall_windows.go:113:2                          nakedret        naked return in func `_EvtSubscribe` with 32 lines of code
plugins/inputs/win_eventlog/zsyscall_windows.go:113:2                          revive          bare-return: avoid using bare returns, please add return expressions
plugins/inputs/win_eventlog/zsyscall_windows.go:116:1                          revive          argument-limit: maximum number of arguments per function exceeded; max 6 but got 7
plugins/inputs/win_eventlog/zsyscall_windows.go:125:15                         staticcheck     SA1019: syscall.Syscall9 has been deprecated since Go 1.18: Use SyscallN instead. 
plugins/inputs/win_eventlog/zsyscall_windows.go:145:2                          nakedret        naked return in func `_EvtRender` with 30 lines of code
plugins/inputs/win_eventlog/zsyscall_windows.go:145:2                          revive          bare-return: avoid using bare returns, please add return expressions
plugins/inputs/win_eventlog/zsyscall_windows.go:149:15                         staticcheck     SA1019: syscall.Syscall has been deprecated since Go 1.18: Use SyscallN instead. 
plugins/inputs/win_eventlog/zsyscall_windows.go:157:2                          nakedret        naked return in func `_EvtClose` with 10 lines of code
plugins/inputs/win_eventlog/zsyscall_windows.go:157:2                          revive          bare-return: avoid using bare returns, please add return expressions
plugins/inputs/win_eventlog/zsyscall_windows.go:161:15                         staticcheck     SA1019: syscall.Syscall6 has been deprecated since Go 1.18: Use SyscallN instead. 
plugins/inputs/win_eventlog/zsyscall_windows.go:178:2                          nakedret        naked return in func `_EvtNext` with 19 lines of code
plugins/inputs/win_eventlog/zsyscall_windows.go:178:2                          revive          bare-return: avoid using bare returns, please add return expressions
plugins/inputs/win_eventlog/zsyscall_windows.go:181:1                          revive          argument-limit: maximum number of arguments per function exceeded; max 6 but got 9
plugins/inputs/win_eventlog/zsyscall_windows.go:192:15                         staticcheck     SA1019: syscall.Syscall9 has been deprecated since Go 1.18: Use SyscallN instead. 
plugins/inputs/win_eventlog/zsyscall_windows.go:199:10                         unconvert       unnecessary conversion
plugins/inputs/win_eventlog/zsyscall_windows.go:212:2                          revive          bare-return: avoid using bare returns, please add return expressions
plugins/inputs/win_eventlog/zsyscall_windows.go:212:2                          nakedret        naked return in func `_EvtFormatMessage` with 32 lines of code
plugins/inputs/win_eventlog/zsyscall_windows.go:216:15                         staticcheck     SA1019: syscall.Syscall6 has been deprecated since Go 1.18: Use SyscallN instead. 
plugins/inputs/win_eventlog/zsyscall_windows.go:234:2                          revive          bare-return: avoid using bare returns, please add return expressions
plugins/inputs/win_eventlog/zsyscall_windows.go:234:2                          nakedret        naked return in func `_EvtOpenPublisherMetadata` with 20 lines of code
plugins/inputs/win_eventlog/zsyscall_windows.go:238:15                         staticcheck     SA1019: syscall.Syscall has been deprecated since Go 1.18: Use SyscallN instead. 
plugins/inputs/win_eventlog/zsyscall_windows.go:250:15                         staticcheck     SA1019: syscall.Syscall has been deprecated since Go 1.18: Use SyscallN instead. 
plugins/inputs/win_perf_counters/kernel32.go:40:2                              unused          field `wYear` is unused
plugins/inputs/win_perf_counters/kernel32.go:41:2                              unused          field `wMonth` is unused
plugins/inputs/win_perf_counters/kernel32.go:42:2                              unused          field `wDayOfWeek` is unused
plugins/inputs/win_perf_counters/kernel32.go:43:2                              unused          field `wDay` is unused
plugins/inputs/win_perf_counters/kernel32.go:44:2                              unused          field `wHour` is unused
plugins/inputs/win_perf_counters/kernel32.go:45:2                              unused          field `wMinute` is unused
plugins/inputs/win_perf_counters/kernel32.go:46:2                              unused          field `wSecond` is unused
plugins/inputs/win_perf_counters/kernel32.go:47:2                              unused          field `wMilliseconds` is unused
plugins/inputs/win_perf_counters/kernel32.go:60:2                              revive          var-naming: don't use underscores in Go names; var krn_FileTimeToSystemTime should be krnFileTimeToSystemTime
plugins/inputs/win_perf_counters/kernel32.go:60:2                              unused          var `krn_FileTimeToSystemTime` is unused
plugins/inputs/win_perf_counters/kernel32.go:61:2                              revive          var-naming: don't use underscores in Go names; var krn_FileTimeToLocalFileTime should be krnFileTimeToLocalFileTime
plugins/inputs/win_perf_counters/kernel32.go:61:2                              unused          var `krn_FileTimeToLocalFileTime` is unused
plugins/inputs/win_perf_counters/kernel32.go:62:2                              revive          var-naming: don't use underscores in Go names; var krn_LocalFileTimeToFileTime should be krnLocalFileTimeToFileTime
plugins/inputs/win_perf_counters/kernel32.go:63:2                              revive          var-naming: don't use underscores in Go names; var krn_WideCharToMultiByte should be krnWideCharToMultiByte
plugins/inputs/win_perf_counters/kernel32.go:63:2                              unused          var `krn_WideCharToMultiByte` is unused
plugins/inputs/win_perf_counters/pdh.go:47:2                                   revive          var-naming: don't use ALL_CAPS in Go names; use CamelCase
plugins/inputs/win_perf_counters/pdh.go:48:2                                   revive          var-naming: don't use ALL_CAPS in Go names; use CamelCase
plugins/inputs/win_perf_counters/pdh.go:49:2                                   revive          var-naming: don't use ALL_CAPS in Go names; use CamelCase
plugins/inputs/win_perf_counters/pdh.go:50:2                                   revive          var-naming: don't use ALL_CAPS in Go names; use CamelCase
plugins/inputs/win_perf_counters/pdh.go:60:2                                   revive          var-naming: don't use ALL_CAPS in Go names; use CamelCase
plugins/inputs/win_perf_counters/pdh.go:61:2                                   revive          var-naming: don't use ALL_CAPS in Go names; use CamelCase
plugins/inputs/win_perf_counters/pdh.go:62:2                                   revive          var-naming: don't use ALL_CAPS in Go names; use CamelCase
plugins/inputs/win_perf_counters/pdh.go:63:2                                   revive          var-naming: don't use ALL_CAPS in Go names; use CamelCase
plugins/inputs/win_perf_counters/pdh.go:64:2                                   revive          var-naming: don't use ALL_CAPS in Go names; use CamelCase
plugins/inputs/win_perf_counters/pdh.go:65:2                                   revive          var-naming: don't use ALL_CAPS in Go names; use CamelCase
plugins/inputs/win_perf_counters/pdh.go:66:2                                   revive          var-naming: don't use ALL_CAPS in Go names; use CamelCase
plugins/inputs/win_perf_counters/pdh.go:67:2                                   revive          var-naming: don't use ALL_CAPS in Go names; use CamelCase
plugins/inputs/win_perf_counters/pdh.go:68:2                                   revive          var-naming: don't use ALL_CAPS in Go names; use CamelCase
plugins/inputs/win_perf_counters/pdh.go:69:2                                   revive          var-naming: don't use ALL_CAPS in Go names; use CamelCase
plugins/inputs/win_perf_counters/pdh.go:70:2                                   revive          var-naming: don't use ALL_CAPS in Go names; use CamelCase
plugins/inputs/win_perf_counters/pdh.go:71:2                                   revive          var-naming: don't use ALL_CAPS in Go names; use CamelCase
plugins/inputs/win_perf_counters/pdh.go:72:2                                   revive          var-naming: don't use ALL_CAPS in Go names; use CamelCase
plugins/inputs/win_perf_counters/pdh.go:73:2                                   revive          var-naming: don't use ALL_CAPS in Go names; use CamelCase
plugins/inputs/win_perf_counters/pdh.go:74:2                                   revive          var-naming: don't use ALL_CAPS in Go names; use CamelCase
plugins/inputs/win_perf_counters/pdh.go:75:2                                   revive          var-naming: don't use ALL_CAPS in Go names; use CamelCase
plugins/inputs/win_perf_counters/pdh.go:76:2                                   revive          var-naming: don't use ALL_CAPS in Go names; use CamelCase
plugins/inputs/win_perf_counters/pdh.go:77:2                                   revive          var-naming: don't use ALL_CAPS in Go names; use CamelCase
plugins/inputs/win_perf_counters/pdh.go:78:2                                   revive          var-naming: don't use ALL_CAPS in Go names; use CamelCase
plugins/inputs/win_perf_counters/pdh.go:79:2                                   revive          var-naming: don't use ALL_CAPS in Go names; use CamelCase
plugins/inputs/win_perf_counters/pdh.go:80:2                                   revive          var-naming: don't use ALL_CAPS in Go names; use CamelCase
plugins/inputs/win_perf_counters/pdh.go:81:2                                   revive          var-naming: don't use ALL_CAPS in Go names; use CamelCase
plugins/inputs/win_perf_counters/pdh.go:82:2                                   revive          var-naming: don't use ALL_CAPS in Go names; use CamelCase
plugins/inputs/win_perf_counters/pdh.go:83:2                                   revive          var-naming: don't use ALL_CAPS in Go names; use CamelCase
plugins/inputs/win_perf_counters/pdh.go:84:2                                   revive          var-naming: don't use ALL_CAPS in Go names; use CamelCase
plugins/inputs/win_perf_counters/pdh.go:85:2                                   revive          var-naming: don't use ALL_CAPS in Go names; use CamelCase
plugins/inputs/win_perf_counters/pdh.go:86:2                                   revive          var-naming: don't use ALL_CAPS in Go names; use CamelCase
plugins/inputs/win_perf_counters/pdh.go:87:2                                   revive          var-naming: don't use ALL_CAPS in Go names; use CamelCase
plugins/inputs/win_perf_counters/pdh.go:88:2                                   revive          var-naming: don't use ALL_CAPS in Go names; use CamelCase
plugins/inputs/win_perf_counters/pdh.go:89:2                                   revive          var-naming: don't use ALL_CAPS in Go names; use CamelCase
plugins/inputs/win_perf_counters/pdh.go:90:2                                   revive          var-naming: don't use ALL_CAPS in Go names; use CamelCase
plugins/inputs/win_perf_counters/pdh.go:91:2                                   revive          var-naming: don't use ALL_CAPS in Go names; use CamelCase
plugins/inputs/win_perf_counters/pdh.go:92:2                                   revive          var-naming: don't use ALL_CAPS in Go names; use CamelCase
plugins/inputs/win_perf_counters/pdh.go:93:2                                   revive          var-naming: don't use ALL_CAPS in Go names; use CamelCase
plugins/inputs/win_perf_counters/pdh.go:94:2                                   revive          var-naming: don't use ALL_CAPS in Go names; use CamelCase
plugins/inputs/win_perf_counters/pdh.go:95:2                                   revive          var-naming: don't use ALL_CAPS in Go names; use CamelCase
plugins/inputs/win_perf_counters/pdh.go:96:2                                   revive          var-naming: don't use ALL_CAPS in Go names; use CamelCase
plugins/inputs/win_perf_counters/pdh.go:97:2                                   revive          var-naming: don't use ALL_CAPS in Go names; use CamelCase
plugins/inputs/win_perf_counters/pdh.go:98:2                                   revive          var-naming: don't use ALL_CAPS in Go names; use CamelCase
plugins/inputs/win_perf_counters/pdh.go:99:2                                   revive          var-naming: don't use ALL_CAPS in Go names; use CamelCase
plugins/inputs/win_perf_counters/pdh.go:100:2                                  revive          var-naming: don't use ALL_CAPS in Go names; use CamelCase
plugins/inputs/win_perf_counters/pdh.go:101:2                                  revive          var-naming: don't use ALL_CAPS in Go names; use CamelCase
plugins/inputs/win_perf_counters/pdh.go:102:2                                  revive          var-naming: don't use ALL_CAPS in Go names; use CamelCase
plugins/inputs/win_perf_counters/pdh.go:103:2                                  revive          var-naming: don't use ALL_CAPS in Go names; use CamelCase
plugins/inputs/win_perf_counters/pdh.go:104:2                                  revive          var-naming: don't use ALL_CAPS in Go names; use CamelCase
plugins/inputs/win_perf_counters/pdh.go:105:2                                  revive          var-naming: don't use ALL_CAPS in Go names; use CamelCase
plugins/inputs/win_perf_counters/pdh.go:106:2                                  revive          var-naming: don't use ALL_CAPS in Go names; use CamelCase
plugins/inputs/win_perf_counters/pdh.go:107:2                                  revive          var-naming: don't use ALL_CAPS in Go names; use CamelCase
plugins/inputs/win_perf_counters/pdh.go:108:2                                  revive          var-naming: don't use ALL_CAPS in Go names; use CamelCase
plugins/inputs/win_perf_counters/pdh.go:109:2                                  revive          var-naming: don't use ALL_CAPS in Go names; use CamelCase
plugins/inputs/win_perf_counters/pdh.go:110:2                                  revive          var-naming: don't use ALL_CAPS in Go names; use CamelCase
plugins/inputs/win_perf_counters/pdh.go:111:2                                  revive          var-naming: don't use ALL_CAPS in Go names; use CamelCase
plugins/inputs/win_perf_counters/pdh.go:112:2                                  revive          var-naming: don't use ALL_CAPS in Go names; use CamelCase
plugins/inputs/win_perf_counters/pdh.go:113:2                                  revive          var-naming: don't use ALL_CAPS in Go names; use CamelCase
plugins/inputs/win_perf_counters/pdh.go:114:2                                  revive          var-naming: don't use ALL_CAPS in Go names; use CamelCase
plugins/inputs/win_perf_counters/pdh.go:115:2                                  revive          var-naming: don't use ALL_CAPS in Go names; use CamelCase
plugins/inputs/win_perf_counters/pdh.go:116:2                                  revive          var-naming: don't use ALL_CAPS in Go names; use CamelCase
plugins/inputs/win_perf_counters/pdh.go:117:2                                  revive          var-naming: don't use ALL_CAPS in Go names; use CamelCase
plugins/inputs/win_perf_counters/pdh.go:118:2                                  revive          var-naming: don't use ALL_CAPS in Go names; use CamelCase
plugins/inputs/win_perf_counters/pdh.go:119:2                                  revive          var-naming: don't use ALL_CAPS in Go names; use CamelCase
plugins/inputs/win_perf_counters/pdh.go:120:2                                  revive          var-naming: don't use ALL_CAPS in Go names; use CamelCase
plugins/inputs/win_perf_counters/pdh.go:121:2                                  revive          var-naming: don't use ALL_CAPS in Go names; use CamelCase
plugins/inputs/win_perf_counters/pdh.go:122:2                                  revive          var-naming: don't use ALL_CAPS in Go names; use CamelCase
plugins/inputs/win_perf_counters/pdh.go:123:2                                  revive          var-naming: don't use ALL_CAPS in Go names; use CamelCase
plugins/inputs/win_perf_counters/pdh.go:124:2                                  revive          var-naming: don't use ALL_CAPS in Go names; use CamelCase
plugins/inputs/win_perf_counters/pdh.go:125:2                                  revive          var-naming: don't use ALL_CAPS in Go names; use CamelCase
plugins/inputs/win_perf_counters/pdh.go:126:2                                  revive          var-naming: don't use ALL_CAPS in Go names; use CamelCase
plugins/inputs/win_perf_counters/pdh.go:127:2                                  revive          var-naming: don't use ALL_CAPS in Go names; use CamelCase
plugins/inputs/win_perf_counters/pdh.go:128:2                                  revive          var-naming: don't use ALL_CAPS in Go names; use CamelCase
plugins/inputs/win_perf_counters/pdh.go:129:2                                  revive          var-naming: don't use ALL_CAPS in Go names; use CamelCase
plugins/inputs/win_perf_counters/pdh.go:130:2                                  revive          var-naming: don't use ALL_CAPS in Go names; use CamelCase
plugins/inputs/win_perf_counters/pdh.go:131:2                                  revive          var-naming: don't use ALL_CAPS in Go names; use CamelCase
plugins/inputs/win_perf_counters/pdh.go:132:2                                  revive          var-naming: don't use ALL_CAPS in Go names; use CamelCase
plugins/inputs/win_perf_counters/pdh.go:133:2                                  revive          var-naming: don't use ALL_CAPS in Go names; use CamelCase
plugins/inputs/win_perf_counters/pdh.go:134:2                                  revive          var-naming: don't use ALL_CAPS in Go names; use CamelCase
plugins/inputs/win_perf_counters/pdh.go:135:2                                  revive          var-naming: don't use ALL_CAPS in Go names; use CamelCase
plugins/inputs/win_perf_counters/pdh.go:136:2                                  revive          var-naming: don't use ALL_CAPS in Go names; use CamelCase
plugins/inputs/win_perf_counters/pdh.go:137:2                                  revive          var-naming: don't use ALL_CAPS in Go names; use CamelCase
plugins/inputs/win_perf_counters/pdh.go:138:2                                  revive          var-naming: don't use ALL_CAPS in Go names; use CamelCase
plugins/inputs/win_perf_counters/pdh.go:139:2                                  revive          var-naming: don't use ALL_CAPS in Go names; use CamelCase
plugins/inputs/win_perf_counters/pdh.go:140:2                                  revive          var-naming: don't use ALL_CAPS in Go names; use CamelCase
plugins/inputs/win_perf_counters/pdh.go:141:2                                  revive          var-naming: don't use ALL_CAPS in Go names; use CamelCase
plugins/inputs/win_perf_counters/pdh.go:142:2                                  revive          var-naming: don't use ALL_CAPS in Go names; use CamelCase
plugins/inputs/win_perf_counters/pdh.go:143:2                                  revive          var-naming: don't use ALL_CAPS in Go names; use CamelCase
plugins/inputs/win_perf_counters/pdh.go:144:2                                  revive          var-naming: don't use ALL_CAPS in Go names; use CamelCase
plugins/inputs/win_perf_counters/pdh.go:145:2                                  revive          var-naming: don't use ALL_CAPS in Go names; use CamelCase
plugins/inputs/win_perf_counters/pdh.go:239:2                                  revive          var-naming: don't use ALL_CAPS in Go names; use CamelCase
plugins/inputs/win_perf_counters/pdh.go:240:2                                  revive          var-naming: don't use ALL_CAPS in Go names; use CamelCase
plugins/inputs/win_perf_counters/pdh.go:241:2                                  revive          var-naming: don't use ALL_CAPS in Go names; use CamelCase
plugins/inputs/win_perf_counters/pdh.go:242:2                                  revive          var-naming: don't use ALL_CAPS in Go names; use CamelCase
plugins/inputs/win_perf_counters/pdh.go:243:2                                  revive          var-naming: don't use ALL_CAPS in Go names; use CamelCase
plugins/inputs/win_perf_counters/pdh.go:244:2                                  revive          var-naming: don't use ALL_CAPS in Go names; use CamelCase
plugins/inputs/win_perf_counters/pdh.go:245:2                                  revive          var-naming: don't use ALL_CAPS in Go names; use CamelCase
plugins/inputs/win_perf_counters/pdh.go:246:2                                  revive          var-naming: don't use ALL_CAPS in Go names; use CamelCase
plugins/inputs/win_perf_counters/pdh.go:247:2                                  revive          var-naming: don't use ALL_CAPS in Go names; use CamelCase
plugins/inputs/win_perf_counters/pdh.go:248:2                                  revive          var-naming: don't use ALL_CAPS in Go names; use CamelCase
plugins/inputs/win_perf_counters/pdh.go:249:2                                  revive          var-naming: don't use ALL_CAPS in Go names; use CamelCase
plugins/inputs/win_perf_counters/pdh.go:250:2                                  revive          var-naming: don't use ALL_CAPS in Go names; use CamelCase
plugins/inputs/win_perf_counters/pdh.go:254:2                                  revive          var-naming: don't use ALL_CAPS in Go names; use CamelCase
plugins/inputs/win_perf_counters/pdh.go:255:2                                  revive          var-naming: don't use ALL_CAPS in Go names; use CamelCase
plugins/inputs/win_perf_counters/pdh.go:263:2                                  revive          var-naming: don't use underscores in Go names; var pdh_AddCounterW should be pdhAddCounterW
plugins/inputs/win_perf_counters/pdh.go:264:2                                  revive          var-naming: don't use underscores in Go names; var pdh_AddEnglishCounterW should be pdhAddEnglishCounterW
plugins/inputs/win_perf_counters/pdh.go:265:2                                  revive          var-naming: don't use underscores in Go names; var pdh_CloseQuery should be pdhCloseQuery
plugins/inputs/win_perf_counters/pdh.go:266:2                                  revive          var-naming: don't use underscores in Go names; var pdh_CollectQueryData should be pdhCollectQueryData
plugins/inputs/win_perf_counters/pdh.go:267:2                                  revive          var-naming: don't use underscores in Go names; var pdh_CollectQueryDataWithTime should be pdhCollectQueryDataWithTime
plugins/inputs/win_perf_counters/pdh.go:268:2                                  revive          var-naming: don't use underscores in Go names; var pdh_GetFormattedCounterValue should be pdhGetFormattedCounterValue
plugins/inputs/win_perf_counters/pdh.go:269:2                                  revive          var-naming: don't use underscores in Go names; var pdh_GetFormattedCounterArrayW should be pdhGetFormattedCounterArrayW
plugins/inputs/win_perf_counters/pdh.go:270:2                                  revive          var-naming: don't use underscores in Go names; var pdh_OpenQuery should be pdhOpenQuery
plugins/inputs/win_perf_counters/pdh.go:271:2                                  revive          var-naming: don't use underscores in Go names; var pdh_ValidatePathW should be pdhValidatePathW
plugins/inputs/win_perf_counters/pdh.go:272:2                                  revive          var-naming: don't use underscores in Go names; var pdh_ExpandWildCardPathW should be pdhExpandWildCardPathW
plugins/inputs/win_perf_counters/pdh.go:273:2                                  revive          var-naming: don't use underscores in Go names; var pdh_GetCounterInfoW should be pdhGetCounterInfoW
plugins/inputs/win_perf_counters/pdh.go:274:2                                  revive          var-naming: don't use underscores in Go names; var pdh_GetRawCounterValue should be pdhGetRawCounterValue
plugins/inputs/win_perf_counters/pdh.go:275:2                                  revive          var-naming: don't use underscores in Go names; var pdh_GetRawCounterArrayW should be pdhGetRawCounterArrayW
plugins/inputs/win_perf_counters/pdh.go:512                                    lll             line is 170 characters
plugins/inputs/win_perf_counters/pdh.go:517                                    lll             line is 163 characters
plugins/inputs/win_perf_counters/pdh.go:534                                    lll             line is 168 characters
plugins/inputs/win_perf_counters/pdh.go:538                                    lll             line is 170 characters
plugins/inputs/win_perf_counters/pdh.go:565:21                                 revive          var-naming: func parameter msgId should be msgID
plugins/inputs/win_perf_counters/pdh.go:580                                    lll             line is 208 characters
plugins/inputs/win_perf_counters/pdh.go:583                                    lll             line is 428 characters
plugins/inputs/win_perf_counters/pdh.go:586                                    lll             line is 321 characters
plugins/inputs/win_perf_counters/pdh_amd64.go:36:6                             revive          var-naming: don't use ALL_CAPS in Go names; use CamelCase
plugins/inputs/win_perf_counters/pdh_amd64.go:42:6                             revive          var-naming: don't use ALL_CAPS in Go names; use CamelCase
plugins/inputs/win_perf_counters/pdh_amd64.go:48:6                             revive          var-naming: don't use ALL_CAPS in Go names; use CamelCase
plugins/inputs/win_perf_counters/pdh_amd64.go:51:2                             unused          field `padding` is unused
plugins/inputs/win_perf_counters/pdh_amd64.go:54:6                             revive          var-naming: don't use ALL_CAPS in Go names; use CamelCase
plugins/inputs/win_perf_counters/pdh_amd64.go:60:6                             revive          var-naming: don't use ALL_CAPS in Go names; use CamelCase
plugins/inputs/win_perf_counters/pdh_amd64.go:66:6                             revive          var-naming: don't use ALL_CAPS in Go names; use CamelCase
plugins/inputs/win_perf_counters/pdh_amd64.go:72:6                             revive          var-naming: don't use ALL_CAPS in Go names; use CamelCase
plugins/inputs/win_perf_counters/pdh_amd64.go:75                               lll             line is 182 characters
plugins/inputs/win_perf_counters/pdh_amd64.go:103                              lll             line is 162 characters
plugins/inputs/win_perf_counters/pdh_amd64.go:116                              lll             line is 173 characters
plugins/inputs/win_perf_counters/pdh_amd64.go:117:6                            revive          var-naming: don't use ALL_CAPS in Go names; use CamelCase
plugins/inputs/win_perf_counters/pdh_amd64.go:118                              lll             line is 180 characters
plugins/inputs/win_perf_counters/pdh_amd64.go:132:6                            revive          var-naming: don't use ALL_CAPS in Go names; use CamelCase
plugins/inputs/win_perf_counters/performance_query.go:20:23                    interfacebloat  the interface has more than 10 methods: 13
plugins/inputs/win_perf_counters/performance_query.go:163:2                    revive          early-return: if c { ... } else { ... return } can be simplified to if !c { ... return } ...
plugins/inputs/win_perf_counters/performance_query.go:166:10                   revive          indent-error-flow: if block ends with a return statement, so drop this else and outdent its block
plugins/inputs/win_perf_counters/performance_query.go:247:89                   revive          empty-lines: extra empty line at the end of a block
plugins/inputs/win_perf_counters/performance_query.go:256:2                    revive          early-return: if c { ... } else { ... return } can be simplified to if !c { ... return } ...
plugins/inputs/win_perf_counters/performance_query.go:259:10                   revive          indent-error-flow: if block ends with a return statement, so drop this else and outdent its block
plugins/inputs/win_perf_counters/win_perf_counters.go:91:1                     revive          function-result-limit: maximum number of return results per function exceeded; max 3 but got 5
plugins/inputs/win_perf_counters/win_perf_counters.go:91:1                     revive          confusing-results: unnamed results of the same type may be confusing, consider using named results
plugins/inputs/win_perf_counters/win_perf_counters.go:168                      lll             line is 204 characters
plugins/inputs/win_perf_counters/win_perf_counters.go:168:1                    revive          argument-limit: maximum number of arguments per function exceeded; max 6 but got 9
plugins/inputs/win_perf_counters/win_perf_counters.go:181:1                    revive          argument-limit: maximum number of arguments per function exceeded; max 6 but got 8
plugins/inputs/win_perf_counters/win_perf_counters.go:367                      lll             line is 164 characters
plugins/inputs/win_perf_counters/win_perf_counters.go:385:19                   errorlint       type assertion on error will fail on wrapped errors. Use errors.As to check for specific errors
plugins/inputs/win_perf_counters/win_perf_counters.go:453:117                  revive          empty-lines: extra empty line at the end of a block
plugins/inputs/win_perf_counters/win_perf_counters.go:469:92                   errorlint       non-wrapping format verb for fmt.Errorf. Use `%w` to format errors
plugins/inputs/win_perf_counters/win_perf_counters.go:485:92                   errorlint       non-wrapping format verb for fmt.Errorf. Use `%w` to format errors
plugins/inputs/win_perf_counters/win_perf_counters.go:490:41                   revive          empty-lines: extra empty line at the start of a block
plugins/inputs/win_perf_counters/win_perf_counters.go:558:19                   errorlint       type assertion on error will fail on wrapped errors. Use errors.As to check for specific errors
plugins/inputs/win_perf_counters/win_perf_counters_integration_test.go:15:59   revive          empty-lines: extra empty line at the end of a block
plugins/inputs/win_perf_counters/win_perf_counters_integration_test.go:110:19  errorlint       type assertion on error will fail on wrapped errors. Use errors.As to check for specific errors
plugins/inputs/win_perf_counters/win_perf_counters_integration_test.go:141:2   revive          unexported-naming: the symbol PerfObject is local, its name should start with a lowercase letter
plugins/inputs/win_perf_counters/win_perf_counters_integration_test.go:179:2   revive          unexported-naming: the symbol PerfObject is local, its name should start with a lowercase letter
plugins/inputs/win_perf_counters/win_perf_counters_integration_test.go:233:2   revive          unexported-naming: the symbol PerfObject is local, its name should start with a lowercase letter
plugins/inputs/win_perf_counters/win_perf_counters_integration_test.go:286:2   revive          unexported-naming: the symbol PerfObject is local, its name should start with a lowercase letter
plugins/inputs/win_perf_counters/win_perf_counters_integration_test.go:339:2   revive          unexported-naming: the symbol PerfObject is local, its name should start with a lowercase letter
plugins/inputs/win_perf_counters/win_perf_counters_integration_test.go:390:2   revive          unexported-naming: the symbol PerfObject is local, its name should start with a lowercase letter
plugins/inputs/win_perf_counters/win_perf_counters_integration_test.go:433:2   revive          unexported-naming: the symbol PerfObject is local, its name should start with a lowercase letter
plugins/inputs/win_perf_counters/win_perf_counters_integration_test.go:481:2   revive          unexported-naming: the symbol PerfObject is local, its name should start with a lowercase letter
plugins/inputs/win_perf_counters/win_perf_counters_integration_test.go:519:2   revive          unexported-naming: the symbol PerfObject is local, its name should start with a lowercase letter
plugins/inputs/win_perf_counters/win_perf_counters_integration_test.go:538:2   staticcheck     SA4006: this value of `err` is never used
plugins/inputs/win_perf_counters/win_perf_counters_integration_test.go:538:2   ineffassign     ineffectual assignment to err
plugins/inputs/win_perf_counters/win_perf_counters_integration_test.go:559:2   revive          unexported-naming: the symbol PerfObject is local, its name should start with a lowercase letter
plugins/inputs/win_perf_counters/win_perf_counters_integration_test.go:582:59  revive          empty-lines: extra empty line at the end of a block
plugins/inputs/win_perf_counters/win_perf_counters_integration_test.go:598:2   revive          unexported-naming: the symbol PerfObject is local, its name should start with a lowercase letter
plugins/inputs/win_perf_counters/win_perf_counters_integration_test.go:631:59  revive          empty-lines: extra empty line at the end of a block
plugins/inputs/win_perf_counters/win_perf_counters_integration_test.go:649:2   revive          unexported-naming: the symbol PerfObject is local, its name should start with a lowercase letter
plugins/inputs/win_perf_counters/win_perf_counters_integration_test.go:687:61  revive          empty-lines: extra empty line at the end of a block
plugins/inputs/win_perf_counters/win_perf_counters_integration_test.go:703:2   revive          unexported-naming: the symbol PerfObject is local, its name should start with a lowercase letter
plugins/inputs/win_perf_counters/win_perf_counters_test.go:34:2                dogsled         declaration has 4 blank identifiers
plugins/inputs/win_perf_counters/win_perf_counters_test.go:73:9                revive          indent-error-flow: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
plugins/inputs/win_perf_counters/win_perf_counters_test.go:74:13               gosimple        S1028: should use fmt.Errorf(...) instead of errors.New(fmt.Sprintf(...))
plugins/inputs/win_perf_counters/win_perf_counters_test.go:74:13               revive          errorf: should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...)
plugins/inputs/win_perf_counters/win_perf_counters_test.go:84:9                revive          indent-error-flow: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
plugins/inputs/win_perf_counters/win_perf_counters_test.go:101:9               revive          indent-error-flow: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
plugins/inputs/win_perf_counters/win_perf_counters_test.go:145:32              unused          func `(*FakePerformanceQuery).findCounterByHandle` is unused
plugins/inputs/win_perf_counters/win_perf_counters_test.go:164:6               revive          early-return: if c { ... } else { ... return } can be simplified to if !c { ... return } ...
plugins/inputs/win_perf_counters/win_perf_counters_test.go:174:11              revive          indent-error-flow: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
plugins/inputs/win_perf_counters/win_perf_counters_test.go:192:6               revive          early-return: if c { ... } else { ... return } can be simplified to if !c { ... return } ...
plugins/inputs/win_perf_counters/win_perf_counters_test.go:202:11              revive          indent-error-flow: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
plugins/inputs/win_perf_counters/win_perf_counters_test.go:235:2               ineffassign     ineffectual assignment to ret
plugins/inputs/win_perf_counters/win_perf_counters_test.go:242                 lll             line is 185 characters
plugins/inputs/win_perf_counters/win_perf_counters_test.go:242:1               revive          argument-limit: maximum number of arguments per function exceeded; max 6 but got 8
plugins/inputs/win_perf_counters/win_perf_counters_test.go:243:2               revive          unexported-naming: the symbol PerfObject is local, its name should start with a lowercase letter
plugins/inputs/win_perf_counters/win_perf_counters_test.go:428:46              revive          empty-lines: extra empty line at the end of a block
plugins/inputs/win_perf_counters/win_perf_counters_test.go:668:73              revive          empty-lines: extra empty line at the end of a block
plugins/inputs/win_perf_counters/win_perf_counters_test.go:813:67              revive          empty-lines: extra empty line at the end of a block
plugins/inputs/win_perf_counters/win_perf_counters_test.go:816:2               revive          unexported-naming: the symbol PerfObject is local, its name should start with a lowercase letter
plugins/inputs/win_perf_counters/win_perf_counters_test.go:956:45              revive          empty-lines: extra empty line at the start of a block
plugins/inputs/win_perf_counters/win_perf_counters_test.go:1352                lll             line is 162 characters
plugins/inputs/win_perf_counters/win_perf_counters_test.go:1450:54             revive          empty-lines: extra empty line at the end of a block
plugins/inputs/win_perf_counters/win_perf_counters_test.go:1731                lll             line is 163 characters
plugins/inputs/win_perf_counters/win_perf_counters_test.go:1926                lll             line is 163 characters
plugins/inputs/win_services/win_services.go:22:6                               errname         the type name `ServiceErr` should conform to the `XxxError` format
plugins/inputs/win_services/win_services.go:33:16                              errorlint       type assertion on error will fail on wrapped errors. Use errors.As to check for specific errors
plugins/inputs/win_services/win_services.go:82:9                               revive          indent-error-flow: if block ends with a return statement, so drop this else and outdent its block
plugins/inputs/win_services/win_services.go:122:59                             errorlint       non-wrapping format verb for fmt.Errorf. Use `%w` to format errors
plugins/inputs/win_services/win_services.go:124:24                             errcheck        Error return value of `scmgr.Disconnect` is not checked
plugins/inputs/win_services/win_services.go:164:57                             errorlint       non-wrapping format verb for fmt.Errorf. Use `%w` to format errors
plugins/inputs/win_services/win_services_integration_test.go:23:24             errcheck        Error return value of `scmgr.Disconnect` is not checked
plugins/inputs/win_services/win_services_integration_test.go:28:18             errcheck        Error return value of `winServices.Init` is not checked
plugins/inputs/win_services/win_services_integration_test.go:43:24             errcheck        Error return value of `scmgr.Disconnect` is not checked
plugins/inputs/win_services/win_services_integration_test.go:48:18             errcheck        Error return value of `winServices.Init` is not checked
plugins/inputs/win_services/win_services_integration_test.go:63:9              errcheck        Error return value of `ws.Init` is not checked
plugins/inputs/win_services/win_services_test.go:51:11                         revive          indent-error-flow: if block ends with a return statement, so drop this else and outdent its block
plugins/inputs/win_services/win_services_test.go:62:9                          revive          indent-error-flow: if block ends with a return statement, so drop this else and outdent its block
plugins/inputs/win_services/win_services_test.go:74:9                          revive          indent-error-flow: if block ends with a return statement, so drop this else and outdent its block
plugins/inputs/win_services/win_services_test.go:89:9                          revive          indent-error-flow: if block ends with a return statement, so drop this else and outdent its block
plugins/inputs/win_services/win_services_test.go:108:9                         revive          indent-error-flow: if block ends with a return statement, so drop this else and outdent its block
plugins/inputs/win_services/win_services_test.go:158:18                        errcheck        Error return value of `winServices.Init` is not checked
plugins/inputs/win_services/win_services_test.go:173:18                        errcheck        Error return value of `winServices.Init` is not checked
plugins/inputs/win_services/win_services_test.go:201:18                        errcheck        Error return value of `winServices.Init` is not checked
plugins/inputs/win_services/win_services_test.go:209:24                        unconvert       unnecessary conversion
plugins/inputs/win_services/win_services_test.go:210:31                        unconvert       unnecessary conversion
plugins/inputs/win_services/win_services_test.go:223:18                        errcheck        Error return value of `winServices.Init` is not checked
plugins/inputs/win_services/win_services_test.go:230:24                        unconvert       unnecessary conversion
plugins/inputs/win_services/win_services_test.go:231:31                        unconvert       unnecessary conversion
plugins/inputs/win_wmi/win_wmi.go:50:15                                        errcheck        Error return value of `v.Clear` is not checked
plugins/inputs/win_wmi/win_wmi.go:113:14                                       errorlint       type assertion on error will fail on wrapped errors. Use errors.As to check for specific errors
plugins/inputs/win_wmi/win_wmi.go:141:24                                       errcheck        Error return value of `serviceRaw.Clear` is not checked
plugins/inputs/win_wmi/win_wmi.go:149:23                                       errcheck        Error return value of `resultRaw.Clear` is not checked
plugins/inputs/win_wmi/win_wmi.go:164:3                                        revive          defer: prefer not to defer inside loops
plugins/inputs/win_wmi/win_wmi.go:171:4                                        revive          defer: prefer not to defer inside loops
plugins/inputs/win_wmi/win_wmi.go:171:20                                       errcheck        Error return value of `prop.Clear` is not checked
plugins/inputs/win_wmi/win_wmi_test.go:20:15                                   revive          var-declaration: should omit type Query from declaration of var testQuery; it will be inferred from the right-hand side
plugins/inputs/win_wmi/win_wmi_test.go:71:13                                   errcheck        Error return value of `plugin.Init` is not checked
@powersj
Copy link
Contributor

powersj commented Apr 6, 2023

next steps: review #13037 and finish up linter issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Requests for new plugin and for new features to existing plugins linter
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants