-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Linter findings for Windows should be fixed #13036
Labels
Comments
zak-pawel
added
feature request
Requests for new plugin and for new features to existing plugins
linter
labels
Apr 5, 2023
This was referenced Apr 5, 2023
next steps: review #13037 and finish up linter issues |
powersj
added a commit
to powersj/telegraf
that referenced
this issue
Jul 11, 2023
powersj
added a commit
to powersj/telegraf
that referenced
this issue
Jul 11, 2023
powersj
added a commit
to powersj/telegraf
that referenced
this issue
Jul 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Use Case
golangci-lint
CI checks in Telegraf repo are by default run only forlinux
.Thus a lot of issues for
windows
code only have accumulated over time.Few
unused...
findings will be false-positives in the same way as they are fordarwin
: #12958They are used for
linux
but not for other OSes.Expected behavior
GOOS=windows make lint-branch
should not return any issues found.Actual behavior
GOOS=windows make lint-branch
founds 360 issues.Additional info
Current findings:
The text was updated successfully, but these errors were encountered: