Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: run make docs with various GOOS #12503

Merged
merged 1 commit into from
Jan 18, 2023
Merged

chore: run make docs with various GOOS #12503

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
chore: run make docs with various GOOS 
In order to correctly update all READMEs during go generate, pass the
primary three GOOS that we support. This way all README will get any
necessary changes.

fixes: #12499
  • Loading branch information
@powersj
powersj committed Jan 13, 2023
commit b7a48d8a8d404533056833e3f99b0ace90bbb666
4 changes: 3 additions & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,9 @@ build_tools:
$(HOSTGO) build -o ./tools/readme_linter/readme_linter$(EXEEXT) ./tools/readme_linter

embed_readme_%:
go generate -run="readme_config_includer/generator$$" ./plugins/$*/...
GOOS=linux go generate -run="readme_config_includer/generator$$" ./plugins/$*/...
GOOS=windows go generate -run="readme_config_includer/generator$$" ./plugins/$*/...
GOOS=darwin go generate -run="readme_config_includer/generator$$" ./plugins/$*/...

.PHONY: docs
docs: build_tools embed_readme_inputs embed_readme_outputs embed_readme_processors embed_readme_aggregators embed_readme_secretstores
Expand Down