chore: run make docs with various GOOS #12503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to correctly update all READMEs during go generate, pass the primary three GOOS that we support. This way all README will get any necessary changes. fixes: influxdata#12499
|
According to the makefile, we also support |
Hipska
added
the
docs
Hipska
approved these changes
Jan 13, 2023
Right, I may need to go dig into this deeper and see which plugins are actually omitted with each GOOS. I know we have linux and windows only plugins, so we may only need to run those two. |
|
Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip. 📦 Click here to get additional PR build artifactsArtifact URLs |
powersj
added
the
ready for final review
srebhan
pushed a commit
that referenced
this pull request
Jan 30, 2023
(cherry picked from commit 7725896)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to correctly update all READMEs during go generate, pass the primary three GOOS that we support. This way all README will get any necessary changes.
fixes: #12499